Issue 1965003002: Don't update subframes on parent frame commits.

Issue 1965003002: Don't update subframes on parent frame commits. (Closed)

Created:
4 years, 7 months ago by Avi (use Gerrit)

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Don't update subframes on parent frame commits. This reverts r371031. This reverts a genuine bugfix, but the bug is needed to mask a much deeper and severe problem. Discussion is ongoing there. BUG=598043, 542299, 600534 , https://github.com/whatwg/html/issues/1191 TEST=disabling CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/1949213002 Cr-Commit-Position: refs/heads/master@{#391906} (cherry picked from commit b48cb31b164c516c109e751f1bd8d9f6eb24b147) Committed: https://chromium.googlesource.com/chromium/src/+/d3db3aaf9ea914e4c2a4df55a8c7448defe8ddb5

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -0 lines)			Patch
M	content/browser/frame_host/navigation_controller_impl.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_browsertest.cc	View	5 chunks	+18 lines, -0 lines	0 comments	Download
M	content/renderer/history_controller.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Avi (use Gerrit)

4 years, 7 months ago (2016-05-10 18:34:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d3db3aaf9ea914e4c2a4df55a8c7448defe8ddb5.