Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1965001: Fix issue with svn copy/move directories. (Closed)

Created:
10 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Fix issue with svn copy/move directories. svn diff would only generate a diff for modified files but the current code would not respect full_move=True. full_move=True is necessary to make it work on the try server. TEST=svn move chrome chrome2; echo foo>>PRESUBMIT.py The try job should fail but the diff should be right. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46566

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use StringIO #

Patch Set 3 : unit test #

Total comments: 1

Patch Set 4 : s/l/line/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -39 lines) Patch
M scm.py View 1 2 3 6 chunks +113 lines, -33 lines 0 comments Download
M tests/scm_unittest.py View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Also optimize by reducing the number of "svn info" calls and temporary directory creations.
10 years, 7 months ago (2010-05-04 20:17:39 UTC) #1
Lei Zhang
http://codereview.chromium.org/1965001/diff/1/2 File scm.py (right): http://codereview.chromium.org/1965001/diff/1/2#newcode45 scm.py:45: """Generates a fake diff from a file.""" Since we ...
10 years, 7 months ago (2010-05-04 20:48:39 UTC) #2
M-A Ruel
10 years, 7 months ago (2010-05-05 13:36:51 UTC) #3
Lei Zhang
10 years, 7 months ago (2010-05-06 00:28:58 UTC) #4
LGTM with small nit.

http://codereview.chromium.org/1965001/diff/7001/4
File scm.py (right):

http://codereview.chromium.org/1965001/diff/7001/4#newcode58
scm.py:58: for l in file_content:
nit: Is that a lower case L? Can you rename the loop variable line>

Powered by Google App Engine
This is Rietveld 408576698