Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1964963002: media: Fix gn deps on media/ targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/ targets Add some needed dependencies for the files in media/filters. BUG=599578 TEST=gn check //media/base/* is clean Committed: https://crrev.com/7874964a97a3545ee09995621dc964c05ea7db9f Cr-Commit-Position: refs/heads/master@{#394966}

Patch Set 1 #

Patch Set 2 : add bug reference + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M media/BUILD.gn View 1 4 chunks +19 lines, -4 lines 0 comments Download
M media/base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jrummell
This is the simplest GN refactoring I could do so that media/base can reference files ...
4 years, 7 months ago (2016-05-10 18:15:23 UTC) #2
DaleCurtis
Hmm, is it that much work to add a media/filters/BUILD.gn file?
4 years, 7 months ago (2016-05-10 19:41:26 UTC) #3
jrummell
It is a pain. filters/ depends on formats/ and video/, formats/ depends on filters/, and ...
4 years, 7 months ago (2016-05-10 23:28:51 UTC) #4
DaleCurtis
I'm okay with some temp changes to get gn check passing, but longer term we ...
4 years, 7 months ago (2016-05-17 02:41:02 UTC) #5
jrummell
Updated.
4 years, 7 months ago (2016-05-19 01:15:22 UTC) #6
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-19 20:42:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964963002/20001
4 years, 7 months ago (2016-05-19 23:23:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 02:45:18 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 02:47:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7874964a97a3545ee09995621dc964c05ea7db9f
Cr-Commit-Position: refs/heads/master@{#394966}

Powered by Google App Engine
This is Rietveld 408576698