Make dart:convert strong mode clean.

Make dart:convert strong mode clean.

Also deprecates the ChunkedConverter.

Committed: https://github.com/dart-lang/sdk/commit/fe1fda076652569884599ce876bb7b3b45aad79b

[floitsch, 2016-05-10 18:27:02]

floitsch@google.com changed reviewers:
+ lrn@google.com

[kevmoo, 2016-05-11 01:02:39]

On 2016/05/10 18:27:02, floitsch wrote:

Wah? Could you share some context on this? Were we able to work-around the
issues w/ LineSplitter? How hacky is this solution?

[Lasse Reichstein Nielsen, 2016-05-11 09:06:14]

lgtm

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/chunked...
File sdk/lib/convert/chunked_conversion.dart (right):

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/chunked...
sdk/lib/convert/chunked_conversion.dart:87: Converter/*=Converter<S, T>*/
converter,
Why not Converter<S,T> in all cases?

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.da...
sdk/lib/convert/json.dart:142: String encode(Object value, {dynamic
toEncodable(dynamic object)}) {
Can you just remove the "dynamic" here?
Or does that mean something else in strong mode?

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.da...
sdk/lib/convert/json.dart:214: [dynamic toEncodable(dynamic nonSerializable)])
Is this necessary?
Is it because an int->int function isn't a subtype of Object->Object?

[floitsch, 2016-05-11 11:20:45]

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/chunked...
File sdk/lib/convert/chunked_conversion.dart (right):

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/chunked...
sdk/lib/convert/chunked_conversion.dart:87: Converter/*=Converter<S, T>*/
converter,
On 2016/05/11 09:06:14, Lasse Reichstein Nielsen wrote:
> Why not Converter<S,T> in all cases?

Because "S, T" in non-strong mode are not connected to their chunked
representation.
For example, LineSplitter in non-strong mode is still a converter, but has
different chunked types (altohugh it doesn't use this class anymore).

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.da...
sdk/lib/convert/json.dart:142: String encode(Object value, {dynamic
toEncodable(dynamic object)}) {
On 2016/05/11 09:06:14, Lasse Reichstein Nielsen wrote:
> Can you just remove the "dynamic" here?
> Or does that mean something else in strong mode?
> 

I had to add it. I'm not really sure which one is better, but I feel like
dynamic->dynamic is what this function does, and as such, that should be its
type.

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.da...
sdk/lib/convert/json.dart:214: [dynamic toEncodable(dynamic nonSerializable)])
On 2016/05/11 09:06:14, Lasse Reichstein Nielsen wrote:
> Is this necessary?
> Is it because an int->int function isn't a subtype of Object->Object?

Unfortunately necessary. Example output of the analyzer:

[warning] Unsound implicit cast from (dynamic) → dynamic to (Object) → Object
(convert/json.dart, line 145, col 28)

[floitsch, 2016-05-11 11:22:23]

On 2016/05/11 01:02:39, kevmoo wrote:
> On 2016/05/10 18:27:02, floitsch wrote:
> 
> Wah? Could you share some context on this? Were we able to work-around the
> issues w/ LineSplitter? How hacky is this solution?

I couldn't make the other approach work nicely. I believe that this is a hack
too, but it was better (and definitely simpler) than the alternative.
LineSplitter is not a Converter anymore (in strong-mode).

The good thing about this change is, that it doesn't affect non-strong mode
users. Their converters will continue working.

[floitsch, 2016-05-11 14:14:54]

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/1964953003/diff/40001/sdk/lib/convert/json.da...
sdk/lib/convert/json.dart:142: String encode(Object value, {dynamic
toEncodable(dynamic object)}) {
On 2016/05/11 11:20:44, floitsch wrote:
> On 2016/05/11 09:06:14, Lasse Reichstein Nielsen wrote:
> > Can you just remove the "dynamic" here?
> > Or does that mean something else in strong mode?
> > 
> 
> I had to add it. I'm not really sure which one is better, but I feel like
> dynamic->dynamic is what this function does, and as such, that should be its
> type.

As discussed in person: removed them again.

[floitsch, 2016-05-11 14:16:02]

Description was changed from

==========
Make dart:convert strong mode clean.

Also removes the ChunkedConverter.
==========

to

==========
Make dart:convert strong mode clean.

Also deprecates the ChunkedConverter.
==========

[floitsch, 2016-05-11 14:17:42]

Description was changed from

==========
Make dart:convert strong mode clean.

Also deprecates the ChunkedConverter.
==========

to

==========
Make dart:convert strong mode clean.

Also deprecates the ChunkedConverter.

Committed:
https://github.com/dart-lang/sdk/commit/fe1fda076652569884599ce876bb7b3b45aad79b
==========

[floitsch, 2016-05-11 14:18:20]

Closing this CL. It was committed, but I had interrupted the process before it
could close it.