Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964903002: Disable output buffering in devtools scripts. (Closed)

Created:
4 years, 7 months ago by ppi
Modified:
4 years, 7 months ago
Reviewers:
tonyg, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Disable output buffering in devtools scripts. Rather than adding .flush() calls manually after each printout, this disables output buffering in devtools scripts altogether. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/12b1499ab574fdcbdcc013fdb39d2d9beea8793e

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/utils.py View 1 2 chunks +11 lines, -0 lines 3 comments Download
M mojo/devtools/common/mojo_benchmark View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/devtools/common/mojo_run View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/devtools/common/mojo_test View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ppi
Hi Ben, Tony, wdyt?
4 years, 7 months ago (2016-05-10 16:13:56 UTC) #3
ppi
4 years, 7 months ago (2016-05-10 16:14:16 UTC) #5
qsr
LGTM if the answer to my question is yes. https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py File mojo/devtools/common/devtoolslib/utils.py (right): https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py#newcode27 mojo/devtools/common/devtoolslib/utils.py:27: ...
4 years, 7 months ago (2016-05-10 16:15:21 UTC) #6
ppi
https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py File mojo/devtools/common/devtoolslib/utils.py (right): https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py#newcode27 mojo/devtools/common/devtoolslib/utils.py:27: sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0) On 2016/05/10 16:15:21, qsr ...
4 years, 7 months ago (2016-05-10 16:17:08 UTC) #7
ppi
https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py File mojo/devtools/common/devtoolslib/utils.py (right): https://codereview.chromium.org/1964903002/diff/20001/mojo/devtools/common/devtoolslib/utils.py#newcode27 mojo/devtools/common/devtoolslib/utils.py:27: sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0) On 2016/05/10 16:17:08, ppi ...
4 years, 7 months ago (2016-05-11 11:21:29 UTC) #8
ppi
4 years, 7 months ago (2016-05-11 11:21:55 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
12b1499ab574fdcbdcc013fdb39d2d9beea8793e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698