Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1964893002: [headless] Use embedded icu data for headless. (Closed)

Created:
4 years, 7 months ago by altimin
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Use embedded icu data for headless. R=alexclarke@chromium.org,skyostil@chromium.org BUG=610673 Committed: https://crrev.com/c29ab96bddc5a4e964a66cb5ed7872771db8ff59 Cr-Commit-Position: refs/heads/master@{#392900}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/args/headless.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
altimin
4 years, 7 months ago (2016-05-10 15:51:12 UTC) #1
alex clarke (OOO till 29th)
lgtm
4 years, 7 months ago (2016-05-10 15:52:03 UTC) #2
Sami
lgtm. https://codereview.chromium.org/1964893002/diff/1/build/args/headless.gn File build/args/headless.gn (right): https://codereview.chromium.org/1964893002/diff/1/build/args/headless.gn#newcode15 build/args/headless.gn:15: enable_nacl = false nit: could you group this ...
4 years, 7 months ago (2016-05-10 15:53:43 UTC) #3
altimin
+dpranke@: Can you please approve this change to headless config?
4 years, 7 months ago (2016-05-10 15:58:31 UTC) #5
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-10 21:04:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964893002/20001
4 years, 7 months ago (2016-05-11 11:09:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 12:15:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:16:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c29ab96bddc5a4e964a66cb5ed7872771db8ff59
Cr-Commit-Position: refs/heads/master@{#392900}

Powered by Google App Engine
This is Rietveld 408576698