Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: content/browser/frame_host/navigation_handle_impl_browsertest.cc

Issue 1964863002: Persist prompt/block download limiter state on renderer-initiated loads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement DidFinishNavigation Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_handle_impl_browsertest.cc b/content/browser/frame_host/navigation_handle_impl_browsertest.cc
index c43f46f4eb5ab93145257359d9b9da962d9e9540..3b96d04a5fc2dbf8a9858eb8f6f3ecbe78c28d9e 100644
--- a/content/browser/frame_host/navigation_handle_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_handle_impl_browsertest.cc
@@ -29,6 +29,7 @@ class NavigationHandleObserver : public WebContentsObserver {
is_error_(false),
is_main_frame_(false),
is_parent_main_frame_(false),
+ is_renderer_initiated_(false),
is_synchronous_(false),
is_srcdoc_(false),
was_redirected_(false),
@@ -48,6 +49,7 @@ class NavigationHandleObserver : public WebContentsObserver {
is_main_frame_ = navigation_handle->IsInMainFrame();
is_parent_main_frame_ = navigation_handle->IsParentMainFrame();
+ is_renderer_initiated_ = navigation_handle->IsRendererInitiated();
is_synchronous_ = navigation_handle->IsSynchronousNavigation();
is_srcdoc_ = navigation_handle->IsSrcdoc();
was_redirected_ = navigation_handle->WasServerRedirect();
@@ -86,6 +88,7 @@ class NavigationHandleObserver : public WebContentsObserver {
bool is_error() { return is_error_; }
bool is_main_frame() { return is_main_frame_; }
bool is_parent_main_frame() { return is_parent_main_frame_; }
+ bool is_renderer_initiated() { return is_renderer_initiated_; }
Charlie Reis 2016/05/11 21:50:03 Please actually check this in some of the tests.
dominickn 2016/05/12 04:22:58 Done.
bool is_synchronous() { return is_synchronous_; }
bool is_srcdoc() { return is_srcdoc_; }
bool was_redirected() { return was_redirected_; }
@@ -104,6 +107,7 @@ class NavigationHandleObserver : public WebContentsObserver {
bool is_error_;
bool is_main_frame_;
bool is_parent_main_frame_;
+ bool is_renderer_initiated_;
bool is_synchronous_;
bool is_srcdoc_;
bool was_redirected_;

Powered by Google App Engine
This is Rietveld 408576698