SharedPageState ensures specified page cache temperature.

SharedPageState ensures specified page cache temperature.

BUG=catapult:#2082

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0536155deb9f920c3657479f683c3b143ee977bf

[kouhei (in TOK), 2016-05-10 07:37:11]

kouhei@chromium.org changed reviewers:
+ nednguyen@google.com

[kouhei (in TOK), 2016-05-10 07:37:12]

ned: Would you take a look?

[nednguyen, 2016-05-10 14:54:07]

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:25: 
nits: add another blank line here

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:30: if temperature == None or
temperature == ANY:
can it ever be None? I thought we set the default value of page.temperature to
ANY?

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:42: tab = browser.tabs[0]
Does this has to be the same tab that we use for running the page? If so, I
think we need to make tab a param of this method & have shared_page_state
passing its self._current_tab instead of browser.

[kouhei (in TOK), 2016-05-11 02:27:56]

Added smoke test as discussed in VC. PTAL

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:25: 
On 2016/05/10 14:54:07, nednguyen wrote:
> nits: add another blank line here

Done.

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:30: if temperature == None or
temperature == ANY:
On 2016/05/10 14:54:07, nednguyen wrote:
> can it ever be None? I thought we set the default value of page.temperature to
> ANY?

Done.

https://codereview.chromium.org/1964843002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:42: tab = browser.tabs[0]
On 2016/05/10 14:54:07, nednguyen wrote:
> Does this has to be the same tab that we use for running the page? If so, I
> think we need to make tab a param of this method & have shared_page_state
> passing its self._current_tab instead of browser.

No, this can be any tab.

[kouhei (in TOK), 2016-05-11 02:28:03]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 02:28:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964843002/1

[commit-bot: I haz the power, 2016-05-11 02:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 02:28:18]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-catapult-committers".
Note that this has nothing to do with OWNERS files.

[nednguyen, 2016-05-11 03:48:41]

lgtm

[kouhei (in TOK), 2016-05-11 04:03:54]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-05-11 04:04:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964843002/20001

[commit-bot: I haz the power, 2016-05-11 04:25:40]

Description was changed from

==========
SharedPageState ensures specified page cache temperature.

BUG=catapult:#2082
==========

to

==========
SharedPageState ensures specified page cache temperature.

BUG=catapult:#2082

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-05-11 04:25:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...