Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 196483005: WebCore::Gradient need not have mutable fields. (Closed)

Created:
6 years, 9 months ago by jbroman
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebCore::Gradient need not have mutable fields. There are no const methods which modify these fields. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/platform/graphics/Gradient.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
This is totally trivial, but not "mutable" is probably better than "mutable", all else equal.
6 years, 9 months ago (2014-03-19 16:25:56 UTC) #1
f(malita)
lgtm
6 years, 9 months ago (2014-03-19 16:33:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/196483005/1
6 years, 9 months ago (2014-03-19 16:34:05 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 16:44:28 UTC) #4
Message was sent while issue was closed.
Change committed as 169560

Powered by Google App Engine
This is Rietveld 408576698