Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 196483003: Add SharedWorkerServiceImpl::CheckWorkerDependency(). (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add SharedWorkerServiceImpl::CheckWorkerDependency(). This method checks the worker dependency of renderer processes and calls IncrementWorkerRefCount and DecrementWorkerRefCount of RenderProcessHostImpl on UI thread if necessary. The old cl (http://crrev.com/256305) was reverted (http://crrev.com/256323) because of the memory leak in MockMessagePortMessageFilter::Send and MockSharedWorkerMessageFilter::Send. This cl has fixed it. The difference between this cl and the old cl is the null value handling of message_queue_ in MockMessagePortMessageFilter::Send and MockSharedWorkerMessageFilter::Send. BUG=327256, 351492 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256749

Patch Set 1 : Original patch #

Patch Set 2 : Fix memory leak #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+736 lines, -9 lines) Patch
M content/browser/message_port_message_filter.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 3 chunks +23 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 9 chunks +107 lines, -3 lines 0 comments Download
A content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 1 2 1 chunk +594 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
horo
kinuko@ Could you please review this? The difference between this cl and the old cl ...
6 years, 9 months ago (2014-03-12 03:59:50 UTC) #1
kinuko
On 2014/03/12 03:59:50, horo wrote: > kinuko@ > Could you please review this? > > ...
6 years, 9 months ago (2014-03-12 04:08:30 UTC) #2
horo
jochen@ Could you please review content/browser/message_port_message_filter.h in this cl?
6 years, 9 months ago (2014-03-12 04:11:55 UTC) #3
horo
On 2014/03/12 04:11:55, horo wrote: > jochen@ > Could you please review content/browser/message_port_message_filter.h in this ...
6 years, 9 months ago (2014-03-12 04:20:46 UTC) #4
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-12 04:21:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/196483003/40001
6 years, 9 months ago (2014-03-12 04:22:31 UTC) #6
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 9 months ago (2014-03-12 04:29:03 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-12 12:39:06 UTC) #8
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-12 23:02:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/196483003/60001
6 years, 9 months ago (2014-03-12 23:08:22 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 05:16:04 UTC) #11
Message was sent while issue was closed.
Change committed as 256749

Powered by Google App Engine
This is Rietveld 408576698