Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1964823003:
Initialize CLD score/language arrays prior to use, for pedantic safety. (Closed)
|
Created:
4 years, 7 months ago by Andrew Hayden (chromium.org) Modified:
4 years, 7 months ago Reviewers:
Takashi Toyoshima CC:
chromium-reviews, rkaplow, Takashi Toyoshima Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInitialize CLD score/language arrays prior to use, for pedantic safety.
BUG=609097
Committed: https://crrev.com/875061e4f515021649992139a8eb0a85104b13ad
Cr-Commit-Position: refs/heads/master@{#392872}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Initialize double array with double values #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 ========== to ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 ==========
+rkaploy +toyoshim as FYI
The CQ bit was checked by andrewhayden@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964823003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
As an OWNER and committer I'm not sure why the CQ is wanting more, but self-"LGTM"? If not, maybe toyoshim@ can do it.
toyoshim@chromium.org changed reviewers: + toyoshim@chromium.org
lgtm with an optional suggestion. Even if you are one of OWNERS, you still need a review from another developer. Exceptional rule here is anyone can review owner's CLs. https://codereview.chromium.org/1964823003/diff/1/components/translate/core/l... File components/translate/core/language_detection/language_detection_util.cc (right): https://codereview.chromium.org/1964823003/diff/1/components/translate/core/l... components/translate/core/language_detection/language_detection_util.cc:94: double normalized_score3[3] = {0, 0, 0}; 0.0 is better for double?
On 2016/05/11 06:08:50, Takashi Toyoshima (still slow) wrote: > lgtm with an optional suggestion. > > Even if you are one of OWNERS, you still need a review from another developer. > Exceptional rule here is anyone can review owner's CLs. > > https://codereview.chromium.org/1964823003/diff/1/components/translate/core/l... > File components/translate/core/language_detection/language_detection_util.cc > (right): > > https://codereview.chromium.org/1964823003/diff/1/components/translate/core/l... > components/translate/core/language_detection/language_detection_util.cc:94: > double normalized_score3[3] = {0, 0, 0}; > 0.0 is better for double? Done. Thanks!
The CQ bit was checked by andrewhayden@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from toyoshim@chromium.org Link to the patchset: https://codereview.chromium.org/1964823003/#ps20001 (title: "Initialize double array with double values")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964823003/20001
Message was sent while issue was closed.
Description was changed from ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 ========== to ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 ========== to ========== Initialize CLD score/language arrays prior to use, for pedantic safety. BUG=609097 Committed: https://crrev.com/875061e4f515021649992139a8eb0a85104b13ad Cr-Commit-Position: refs/heads/master@{#392872} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/875061e4f515021649992139a8eb0a85104b13ad Cr-Commit-Position: refs/heads/master@{#392872} |
