Trace FrameLoader object snapshots

Trace FrameLoader object snapshots

BUG=580902
Committed: https://crrev.com/f75e1033c8f411c983ba0342a480bca4eb8fdd1a
Cr-Commit-Position: refs/heads/master@{#392841}

[kouhei (in TOK), 2016-05-10 03:08:38]

kouhei@chromium.org changed reviewers:
+ kinuko@chromium.org, tzik@chromium.org

[kouhei (in TOK), 2016-05-10 03:49:24]

kouhei@chromium.org changed reviewers:
+ ksakamoto@google.com

[kouhei (in TOK), 2016-05-10 05:49:33]

Description was changed from

==========
Trace FrameLoader object snapshots

BUG=580902
==========

to

==========
Trace FrameLoader object snapshots

BUG=580902
==========

[kouhei (in TOK), 2016-05-10 05:49:33]

kouhei@chromium.org changed reviewers:
+ ksakamoto@chromium.org
- ksakamoto@google.com

[kouhei (in TOK), 2016-05-10 05:49:45]

+ksakamoto@chrom

[Kunihiko Sakamoto, 2016-05-10 06:06:15]

lgtm w/ one nit

https://codereview.chromium.org/1964803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/1964803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1559:
tracedValue->setString("id_ref", String::format("0x%" PRIx64,
static_cast<uint64_t>(reinterpret_cast<intptr_t>(m_frame.get()))));
I'm told that the correct way to do this is:
String::format("0x%" PRIxPTR, reinterpret_cast<uintptr_t>(m_frame.get())));

[kouhei (in TOK), 2016-05-10 07:01:35]

kouhei@chromium.org changed reviewers:
+ japhet@chromium.org

[kouhei (in TOK), 2016-05-10 07:01:36]

japhet: Would you take a look?

https://codereview.chromium.org/1964803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/1964803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1559:
tracedValue->setString("id_ref", String::format("0x%" PRIx64,
static_cast<uint64_t>(reinterpret_cast<intptr_t>(m_frame.get()))));
On 2016/05/10 06:06:15, Kunihiko Sakamoto wrote:
> I'm told that the correct way to do this is:
> String::format("0x%" PRIxPTR, reinterpret_cast<uintptr_t>(m_frame.get())));

Done.

[kinuko, 2016-05-10 07:17:22]

lgtm

[Nate Chapin, 2016-05-10 23:53:27]

lgtm

[Nate Chapin, 2016-05-10 23:53:37]

lgtm

[kouhei (in TOK), 2016-05-10 23:54:10]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-05-10 23:54:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
ksakamoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1964803002/#ps40001
(title: "ksakamoto@ review")

[commit-bot: I haz the power, 2016-05-10 23:54:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964803002/40001

[commit-bot: I haz the power, 2016-05-11 00:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 00:09:01]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[kouhei (in TOK), 2016-05-11 02:03:13]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-05-11 02:03:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
ksakamoto@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1964803002/#ps80001
(title: "win failure")

[commit-bot: I haz the power, 2016-05-11 02:03:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964803002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964803002/80001

[tzik, 2016-05-11 02:30:00]

lgtm

[commit-bot: I haz the power, 2016-05-11 03:30:38]

Description was changed from

==========
Trace FrameLoader object snapshots

BUG=580902
==========

to

==========
Trace FrameLoader object snapshots

BUG=580902
==========

[commit-bot: I haz the power, 2016-05-11 03:30:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-11 03:38:49]

Description was changed from

==========
Trace FrameLoader object snapshots

BUG=580902
==========

to

==========
Trace FrameLoader object snapshots

BUG=580902

Committed: https://crrev.com/f75e1033c8f411c983ba0342a480bca4eb8fdd1a
Cr-Commit-Position: refs/heads/master@{#392841}
==========

[commit-bot: I haz the power, 2016-05-11 03:38:50]

Patchset 5 (id:??) landed as
https://crrev.com/f75e1033c8f411c983ba0342a480bca4eb8fdd1a
Cr-Commit-Position: refs/heads/master@{#392841}