Revert of [Reland 1] Pepper takes ownership of a mailbox before passing it to the texture layer.

Revert of [Reland 1] Pepper takes ownership of a mailbox before passing it to the texture layer. (patchset #8 id:140001 of https://codereview.chromium.org/1943513002/ )

Reason for revert:
Breaks WebGL on CrOS, crbug.com/610411.

Original issue's description:
> [Reland 1] Pepper takes ownership of a mailbox before passing it to the texture layer.
>
> This CL makes three changes from the original.
>
> 1. Replace a call to std::remove_if() with vec.erase(std::remove_if(), ...).
> This was a logic error in the original CL that caused a crash any time the size
> of the buffer was changed. This CL also adds a test that catches this bug.
>
> 2. Add some simple reference counting to PepperPluginInstanceImpl to track the
> fact that a cc::TextureMailbox may be passed to |texture_layer_| more than once.
>
> 3. The SyncToken signal is now processed in the context of its own message:
> WaitSyncToken.
>
> > I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with
> > GpuCommandBufferMsg_TakeFrontBuffer and GpuCommandBufferMsg_ReturnFrontBuffer.
> > TakeFrontBuffer gives ownership of the front buffer to the client. When the
> > client returns it with ReturnFrontBuffer, the command buffer may choose to reuse
> > it.
> >
> > This means that pepper no longer needs to use
> > SetTextureMailboxWithoutReleaseCallback.
>
> BUG=350204, 602484
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> TEST=Run Chromium with the Pepper Flash plugin. Visit a site that supports Flash
> video, such as http://vudu.com. Start playing a video, and then fullscreen the
> video. Observe that Chromium does not crash. Please extensively test Chromium on
> Flash 3D games and Flash video and make sure nothing else is working
> incorrectly.
> TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/4734ed1b6740b772201b8accb3e2bd88cdea5c99
> Cr-Commit-Position: refs/heads/master@{#391686}

TBR=piman@chromium.org,ccameron@chromium.org,bbudge@chromium.org,tsepez@chromium.org,sky@chromium.org,sunnyps@chromium.org,erikchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=350204, 602484
Committed: https://crrev.com/8c46143b0ca822b010d5f9c284eadc810b0678e8
Cr-Commit-Position: refs/heads/master@{#392548}

[ilja, 2016-05-10 02:17:55]

Created Revert of [Reland 1] Pepper takes ownership of a mailbox before passing
it to the texture layer.

[commit-bot: I haz the power, 2016-05-10 02:18:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964793002/1

[commit-bot: I haz the power, 2016-05-10 02:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 02:18:45]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hshi1, 2016-05-10 02:21:04]

hshi@chromium.org changed reviewers:
+ hshi@chromium.org

[hshi1, 2016-05-10 02:21:04]

lgtm

[ilja, 2016-05-10 04:20:53]

The CQ bit was checked by ihf@chromium.org

[commit-bot: I haz the power, 2016-05-10 04:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964793002/1

[commit-bot: I haz the power, 2016-05-10 05:14:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-10 05:15:38]

Description was changed from

==========
Revert of [Reland 1] Pepper takes ownership of a mailbox before passing it to
the texture layer. (patchset #8 id:140001 of
https://codereview.chromium.org/1943513002/ )

Reason for revert:
Breaks WebGL on CrOS, crbug.com/610411.

Original issue's description:
> [Reland 1] Pepper takes ownership of a mailbox before passing it to the
texture layer.
> 
> This CL makes three changes from the original.
> 
> 1. Replace a call to std::remove_if() with vec.erase(std::remove_if(), ...).
> This was a logic error in the original CL that caused a crash any time the
size
> of the buffer was changed. This CL also adds a test that catches this bug.
> 
> 2. Add some simple reference counting to PepperPluginInstanceImpl to track the
> fact that a cc::TextureMailbox may be passed to |texture_layer_| more than
once.
> 
> 3. The SyncToken signal is now processed in the context of its own message:
> WaitSyncToken.
> 
> > I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with
> > GpuCommandBufferMsg_TakeFrontBuffer and
GpuCommandBufferMsg_ReturnFrontBuffer.
> > TakeFrontBuffer gives ownership of the front buffer to the client. When the
> > client returns it with ReturnFrontBuffer, the command buffer may choose to
reuse
> > it.
> >
> > This means that pepper no longer needs to use
> > SetTextureMailboxWithoutReleaseCallback.
> 
> BUG=350204, 602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> TEST=Run Chromium with the Pepper Flash plugin. Visit a site that supports
Flash
> video, such as http://vudu.com. Start playing a video, and then fullscreen the
> video. Observe that Chromium does not crash. Please extensively test Chromium
on
> Flash 3D games and Flash video and make sure nothing else is working
> incorrectly.
> TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org
> 
> Committed: https://crrev.com/4734ed1b6740b772201b8accb3e2bd88cdea5c99
> Cr-Commit-Position: refs/heads/master@{#391686}

TBR=piman@chromium.org,ccameron@chromium.org,bbudge@chromium.org,tsepez@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=350204, 602484
==========

to

==========
Revert of [Reland 1] Pepper takes ownership of a mailbox before passing it to
the texture layer. (patchset #8 id:140001 of
https://codereview.chromium.org/1943513002/ )

Reason for revert:
Breaks WebGL on CrOS, crbug.com/610411.

Original issue's description:
> [Reland 1] Pepper takes ownership of a mailbox before passing it to the
texture layer.
>
> This CL makes three changes from the original.
>
> 1. Replace a call to std::remove_if() with vec.erase(std::remove_if(), ...).
> This was a logic error in the original CL that caused a crash any time the
size
> of the buffer was changed. This CL also adds a test that catches this bug.
>
> 2. Add some simple reference counting to PepperPluginInstanceImpl to track the
> fact that a cc::TextureMailbox may be passed to |texture_layer_| more than
once.
>
> 3. The SyncToken signal is now processed in the context of its own message:
> WaitSyncToken.
>
> > I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with
> > GpuCommandBufferMsg_TakeFrontBuffer and
GpuCommandBufferMsg_ReturnFrontBuffer.
> > TakeFrontBuffer gives ownership of the front buffer to the client. When the
> > client returns it with ReturnFrontBuffer, the command buffer may choose to
reuse
> > it.
> >
> > This means that pepper no longer needs to use
> > SetTextureMailboxWithoutReleaseCallback.
>
> BUG=350204, 602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> TEST=Run Chromium with the Pepper Flash plugin. Visit a site that supports
Flash
> video, such as http://vudu.com. Start playing a video, and then fullscreen the
> video. Observe that Chromium does not crash. Please extensively test Chromium
on
> Flash 3D games and Flash video and make sure nothing else is working
> incorrectly.
> TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/4734ed1b6740b772201b8accb3e2bd88cdea5c99
> Cr-Commit-Position: refs/heads/master@{#391686}

TBR=piman@chromium.org,ccameron@chromium.org,bbudge@chromium.org,tsepez@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=350204, 602484

Committed: https://crrev.com/8c46143b0ca822b010d5f9c284eadc810b0678e8
Cr-Commit-Position: refs/heads/master@{#392548}
==========

[commit-bot: I haz the power, 2016-05-10 05:15:40]

Patchset 1 (id:??) landed as
https://crrev.com/8c46143b0ca822b010d5f9c284eadc810b0678e8
Cr-Commit-Position: refs/heads/master@{#392548}