Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 1964773002: Render Unicode control characters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 Google Inc. All rights reserved. 2 * Copyright (c) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 BlackBerry Limited. All rights reserved. 3 * Copyright (C) 2013 BlackBerry Limited. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 14 matching lines...) Expand all
25 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 25 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 26 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30 */ 30 */
31 31
32 #include "platform/fonts/shaping/HarfBuzzShaper.h" 32 #include "platform/fonts/shaping/HarfBuzzShaper.h"
33 33
34 #include "platform/Logging.h" 34 #include "platform/Logging.h"
35 #include "platform/RuntimeEnabledFeatures.h"
35 #include "platform/fonts/Font.h" 36 #include "platform/fonts/Font.h"
36 #include "platform/fonts/FontFallbackIterator.h" 37 #include "platform/fonts/FontFallbackIterator.h"
37 #include "platform/fonts/GlyphBuffer.h" 38 #include "platform/fonts/GlyphBuffer.h"
38 #include "platform/fonts/UTF16TextIterator.h" 39 #include "platform/fonts/UTF16TextIterator.h"
39 #include "platform/fonts/opentype/OpenTypeCapsSupport.h" 40 #include "platform/fonts/opentype/OpenTypeCapsSupport.h"
40 #include "platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h" 41 #include "platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h"
41 #include "platform/fonts/shaping/HarfBuzzFace.h" 42 #include "platform/fonts/shaping/HarfBuzzFace.h"
42 #include "platform/fonts/shaping/RunSegmenter.h" 43 #include "platform/fonts/shaping/RunSegmenter.h"
43 #include "platform/fonts/shaping/ShapeResultInlineHeaders.h" 44 #include "platform/fonts/shaping/ShapeResultInlineHeaders.h"
44 #include "platform/text/Character.h" 45 #include "platform/text/Character.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 source = stringFor8BitRun.characters16(); 92 source = stringFor8BitRun.characters16();
92 } else { 93 } else {
93 source = run.characters16(); 94 source = run.characters16();
94 } 95 }
95 96
96 *destinationLength = 0; 97 *destinationLength = 0;
97 while (position < length) { 98 while (position < length) {
98 UChar32 character; 99 UChar32 character;
99 U16_NEXT(source, position, length, character); 100 U16_NEXT(source, position, length, character);
100 // Don't normalize tabs as they are not treated as spaces for word-end. 101 // Don't normalize tabs as they are not treated as spaces for word-end.
101 if (run.normalizeSpace() && Character::isNormalizedCanvasSpaceCharacter( character)) 102 if (run.normalizeSpace() && Character::isNormalizedCanvasSpaceCharacter( character)) {
102 character = spaceCharacter; 103 character = spaceCharacter;
103 else if (Character::treatAsSpace(character) && character != noBreakSpace Character) 104 } else if (Character::treatAsSpace(character) && character != noBreakSpa ceCharacter) {
104 character = spaceCharacter; 105 character = spaceCharacter;
105 else if (Character::treatAsZeroWidthSpaceInComplexScript(character)) 106 } else if (!RuntimeEnabledFeatures::renderUnicodeControlCharactersEnable d()
107 && Character::legacyTreatAsZeroWidthSpaceInComplexScript(character)) {
106 character = zeroWidthSpaceCharacter; 108 character = zeroWidthSpaceCharacter;
109 } else if (Character::treatAsZeroWidthSpaceInComplexScript(character)) {
110 character = zeroWidthSpaceCharacter;
111 }
107 112
108 U16_APPEND(destination, *destinationLength, length, character, error); 113 U16_APPEND(destination, *destinationLength, length, character, error);
109 ASSERT_UNUSED(error, !error); 114 ASSERT_UNUSED(error, !error);
110 } 115 }
111 } 116 }
112 117
113 HarfBuzzShaper::HarfBuzzShaper(const Font* font, const TextRun& run) 118 HarfBuzzShaper::HarfBuzzShaper(const Font* font, const TextRun& run)
114 : Shaper(font, run) 119 : Shaper(font, run)
115 , m_normalizedBufferLength(0) 120 , m_normalizedBufferLength(0)
116 { 121 {
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 result->m_width = run->m_width; 672 result->m_width = run->m_width;
668 result->m_numGlyphs = count; 673 result->m_numGlyphs = count;
669 ASSERT(result->m_numGlyphs == count); // no overflow 674 ASSERT(result->m_numGlyphs == count); // no overflow
670 result->m_hasVerticalOffsets = fontData->platformData().isVerticalAnyUpright (); 675 result->m_hasVerticalOffsets = fontData->platformData().isVerticalAnyUpright ();
671 result->m_runs.append(run.release()); 676 result->m_runs.append(run.release());
672 return result.release(); 677 return result.release();
673 } 678 }
674 679
675 680
676 } // namespace blink 681 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698