Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 196473018: Add safe blob-over-IPC transfer from browser->renderer for IDB. (Closed)

Created:
6 years, 9 months ago by ericu
Modified:
6 years, 9 months ago
Reviewers:
Tom Sepez, jsbell, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Add safe blob-over-IPC transfer from browser->renderer for IDB. BUG=108012 R=cmumford,jsbell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257537

Patch Set 1 #

Patch Set 2 : remove extra newline #

Total comments: 5

Patch Set 3 : style tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 5 chunks +29 lines, -1 line 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ericu
Patch #6
6 years, 9 months ago (2014-03-14 00:55:49 UTC) #1
jsbell
LGTM +tsepez for IPC messages review https://codereview.chromium.org/196473018/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.cc File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right): https://codereview.chromium.org/196473018/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.cc#newcode177 content/browser/indexed_db/indexed_db_dispatcher_host.cc:177: DCHECK(blob_data_handle_map_.find(uuid) == blob_data_handle_map_.end()); ...
6 years, 9 months ago (2014-03-14 21:32:53 UTC) #2
Tom Sepez
Messages LGTM.
6 years, 9 months ago (2014-03-14 21:35:33 UTC) #3
ericu
https://codereview.chromium.org/196473018/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.cc File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right): https://codereview.chromium.org/196473018/diff/20001/content/browser/indexed_db/indexed_db_dispatcher_host.cc#newcode177 content/browser/indexed_db/indexed_db_dispatcher_host.cc:177: DCHECK(blob_data_handle_map_.find(uuid) == blob_data_handle_map_.end()); On 2014/03/14 21:32:54, jsbell wrote: > ...
6 years, 9 months ago (2014-03-17 19:46:18 UTC) #4
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 9 months ago (2014-03-17 19:46:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/196473018/40001
6 years, 9 months ago (2014-03-17 19:48:30 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 00:02:01 UTC) #7
Message was sent while issue was closed.
Change committed as 257537

Powered by Google App Engine
This is Rietveld 408576698