[Profiles] Don't treat GAIA names differently than regular profile names.

[Profiles] Don't treat GAIA names differently than regular profile names.

This also half-enables the ability to use the Gaia profile pictures as the profile 
avatar on the main truck if you had previously used the 
--new-profile-management or --gaia-profile-info flags before. (Because
the chrome://settings doesn't enable setting it outside the flag).

There was special, ancient logic that treated profiles using a Gaia names 
as "special", which didn't mix well with syncing of the profile name. Basically, 
you could either use a synced profile name, or a Gaia name, but not both 
(i.e. download the synced name and then be able to rename the profile back
to its Gaia name).

I think this fixes it. and shouldn't really break a lot of other things, as the two 
functions that I've deleted weren't really used anywhere.

BUG=352090
TEST=Be able to rename a local profile. Be able to sign in to a profile, and if 
this is the first time you're doing it, the profile name should be the user's Gaia
 first name. Be able to rename this profile to a custom name, and back to the
 Gaia name. Finally, if you're signing in with this account on a different profile,
 the name that you last left off should be the one that is synced/used.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259161

[noms (inactive), 2014-03-13 20:17:05]

Here is a thing I did to profiles that may or may not (leaning towards may not)
break everything :)

[noms (inactive), 2014-03-18 15:58:50]

ping :)

[noms (inactive), 2014-03-18 19:25:06]

I originally wanted to also fix crbug.com/351970 as part of this patch as it's
sort of related, but I think that one will involve a different kind of fix, so I
will move it to a separate CL. So I think this CL is still done with changes :)

[rpetterson, 2014-03-20 22:58:17]

Just to make sure I'm understanding properly, the order of name precedence goes:

1) Custom name
2) GAIA name
3) Default name

And we no longer need the migrated cache info because if there is a GAIA name,
we will set it.

I'm still a little fuzzy on how we know whether to return a custom name or GAIA
name. Can you elaborate a bit more on that?

https://codereview.chromium.org/196473015/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profiles_state.cc (right):

https://codereview.chromium.org/196473015/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profiles_state.cc:91:
base::UTF16ToUTF8(new_profile_name));
Do you need to know if it's a GAIA name or custom name?

[noms (inactive), 2014-03-21 14:31:59]

Yeah, that is the correct name precedence.

The logic for returning a custom or gaia name is:
- what is the current value stored in the property kNameKey (this is the
"custom" name)? If it's something like "First user" or "Person 1" or "Lemonade",
and the user hasn't explicitly customized it, then this is a default name, and
we can do better: Is there a Gaia name available? Then return that. 
- whenever you edit the name by hand we also flip the "user has chosen this
name", so that if you really want to call yourself Lemonade, you can, and we
won't keep defaulting to the Gaia name

There is currently a bug, however where if you've synced in the pre-mirror work
your name, it was probably synced as First User and this code considers it a
"Custom" synced name, and displays it. Roger is working on a CL so that in that
particular case we default to the Gaia name (but again, if you want to set your
name to Lemonade, you can).

Does this help a little?

https://codereview.chromium.org/196473015/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profiles_state.cc (right):

https://codereview.chromium.org/196473015/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profiles_state.cc:91:
base::UTF16ToUTF8(new_profile_name));
You don't. You're just updating the display, custom name, since the Gaia name is
saved separately. 

On 2014/03/20 22:58:17, rpetterson wrote:
> Do you need to know if it's a GAIA name or custom name?

[noms (inactive), 2014-03-24 21:19:27]

Rachel: ping! :)

[noms (inactive), 2014-03-24 21:19:37]

Rachel: ping! :)

[rpetterson, 2014-03-24 21:49:46]

Eep! Thank you for the ping. This had totally fallen off my plate after I read
your response and nodded to myself. LGTM!

[noms (inactive), 2014-03-25 00:29:57]

No problem. Thanks!

[noms (inactive), 2014-03-25 00:30:02]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:31:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/196473015/20001

[commit-bot: I haz the power, 2014-03-25 00:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:37:06]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[noms (inactive), 2014-03-25 03:38:42]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-03-25 03:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/196473015/20001

[commit-bot: I haz the power, 2014-03-25 05:59:42]

Change committed as 259161