Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964703002: Refresh Public Suffic List to the latest version (Closed)

Created:
4 years, 7 months ago by Ryan Sleevi
Modified:
4 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision 030a5f3d578434428bbb506f315539f0c4f67f6c (2016-04-04) to revision 2226f9cc92213d0d68a74ecb535b15b3af00388a (2016-05-09) R=pkasting@chromium.org BUG=610496 Committed: https://crrev.com/255bd157ac8f99fa19ab3d1142aa0524fc12aff2 Cr-Commit-Position: refs/heads/master@{#392487}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -7 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 18 chunks +86 lines, -6 lines 1 comment Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 33 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ryan Sleevi
Peter: For your review
4 years, 7 months ago (2016-05-09 22:44:40 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/1964703002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/1964703002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode11224 net/base/registry_controlled_domains/effective_tld_names.dat:11224: *.0emm.com What an odd domain
4 years, 7 months ago (2016-05-09 22:48:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964703002/1
4 years, 7 months ago (2016-05-09 22:49:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 00:00:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964703002/1
4 years, 7 months ago (2016-05-10 00:20:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 00:25:32 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 00:27:19 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/255bd157ac8f99fa19ab3d1142aa0524fc12aff2
Cr-Commit-Position: refs/heads/master@{#392487}

Powered by Google App Engine
This is Rietveld 408576698