Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 19647006: Add AssertSmi() in x64 MacroAssembler::SmiTest(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Add AssertSmi() in x64 MacroAssembler::SmiTest(). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Going for the bonus points :-)
7 years, 5 months ago (2013-07-22 06:59:37 UTC) #1
Sven Panne
lgtm
7 years, 5 months ago (2013-07-22 07:07:31 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-22 07:09:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698