Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: services/js/test/echo.js

Issue 1964673002: Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/js/echo_apptest.cc ('k') | services/js/test/echo_service.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/test/echo.js
diff --git a/services/js/test/echo.js b/services/js/test/echo.js
index 17808648564d269efd17ab38c4b4d6612a63f5e6..871837c11f5e5d3ed3091aee1613d44c1c9671d7 100644
--- a/services/js/test/echo.js
+++ b/services/js/test/echo.js
@@ -17,23 +17,6 @@ define("main", [
return Promise.resolve({value: s});
}
- // This method is only used by the ShareEchoService test.
- shareEchoService() {
- var echoTargetURL = echoApp.url.replace("echo.js", "echo_target.js");
- var targetSP = echoApp.shell.connectToApplication(echoTargetURL);
- // This Promise resolves after echo_target.js has called the echoString()
- // method defined on the local EchoService implementation. For its part,
- // the target application quits after one successful call to echoString().
- return new Promise(function(resolve) {
- targetSP.provideService(EchoService, function() {
- this.echoString = function(s) {
- resolve({ok: true});
- return Promise.resolve({value: s});
- }
- });
- });
- }
-
quit() {
echoApp.quit();
}
« no previous file with comments | « services/js/echo_apptest.cc ('k') | services/js/test/echo_service.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698