Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: services/js/echo_apptest.cc

Issue 1964673002: Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/js/test/echo.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/echo_apptest.cc
diff --git a/services/js/echo_apptest.cc b/services/js/echo_apptest.cc
index 6109d5cfeb5403b45b5efca1ef5ea781dfa186b0..9d7f3438db1534cf5ddf12728c367755623cb0cc 100644
--- a/services/js/echo_apptest.cc
+++ b/services/js/echo_apptest.cc
@@ -73,14 +73,5 @@ TEST_F(JSEchoTest, EchoNullString) {
echo_service_->Quit();
}
-// Verify that a JS app's ServiceProvider can request and provide services.
-// This test exercises the same code paths as examples/js/share_echo.js.
-TEST_F(JSEchoTest, ShareEchoService) {
- bool returned_value = false;
- EXPECT_TRUE(echo_service_->ShareEchoService(&returned_value));
- EXPECT_TRUE(returned_value);
- echo_service_->Quit();
-}
-
} // namespace
} // namespace js
« no previous file with comments | « no previous file | services/js/test/echo.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698