Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: webrtc/api/dtlsidentitystore.h

Issue 1964663004: Removed old RequestIdentity function signature (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/dtlsidentitystore.h
diff --git a/webrtc/api/dtlsidentitystore.h b/webrtc/api/dtlsidentitystore.h
index 5ded1f112b367308d84e26e7273405fec98ada2f..e25b79591a76ee7465f6d344c99d93d4dd328b51 100644
--- a/webrtc/api/dtlsidentitystore.h
+++ b/webrtc/api/dtlsidentitystore.h
@@ -57,25 +57,10 @@ class DtlsIdentityStoreInterface {
// The |observer| will be called when the requested identity is ready, or when
// identity generation fails.
- // TODO(torbjorng,hbos): There are currently two versions of RequestIdentity,
- // with default implementation to call the other version of itself (so that a
- // call can be made regardless of which version has been overridden). The 1st
- // version exists because it is currently implemented in chromium. The 2nd
- // version will become the one and only RequestIdentity as soon as chromium
- // implements the correct version. crbug.com/544902, webrtc:5092.
- virtual void RequestIdentity(
- rtc::KeyParams key_params,
- const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) {
- // Add default ("null") expiration.
- RequestIdentity(key_params, rtc::Optional<uint64_t>(), observer);
- }
virtual void RequestIdentity(
const rtc::KeyParams& key_params,
const rtc::Optional<uint64_t>& expires_ms,
- const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) {
- // Drop |expires|.
- RequestIdentity(key_params, observer);
- }
+ const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) = 0;
};
// The WebRTC default implementation of DtlsIdentityStoreInterface.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698