Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1964663004: Removed old RequestIdentity function signature (Closed)

Created:
4 years, 7 months ago by hbos
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed old DtlsIdentityRequestObserver::RequestIdentity function signature since the new signature is used everywhere. BUG=chromium:544902, webrtc:5092 R=mattdr@google.com, perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/faa78dc38d060b0a18199a43a60e31b06f06aed7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M webrtc/api/dtlsidentitystore.h View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hbos
Please take a look perkj. Trivial change.
4 years, 7 months ago (2016-05-10 08:22:29 UTC) #3
hbos
+mattdr again (does it not recognize your @webrtc or does it just look that way?)
4 years, 7 months ago (2016-05-10 13:15:36 UTC) #5
mattdr
lgtm
4 years, 7 months ago (2016-05-11 00:23:38 UTC) #6
perkj_webrtc
lgtm
4 years, 7 months ago (2016-05-11 08:12:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964663004/1
4 years, 7 months ago (2016-05-11 08:12:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3896)
4 years, 7 months ago (2016-05-11 08:17:44 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faa78dc38d060b0a18199a43a60e31b06f06aed7 Cr-Commit-Position: refs/heads/master@{#12681}
4 years, 7 months ago (2016-05-11 08:23:39 UTC) #13
hbos
4 years, 7 months ago (2016-05-11 08:23:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
faa78dc38d060b0a18199a43a60e31b06f06aed7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698