Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: telemetry/telemetry/value/scalar.py

Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/value/scalar.py
diff --git a/telemetry/telemetry/value/scalar.py b/telemetry/telemetry/value/scalar.py
index 2789b81319e9224333c4178683afc3b23dceebec..8dcd482f7fb0f6ee4758f854c91af4c2c452649c 100644
--- a/telemetry/telemetry/value/scalar.py
+++ b/telemetry/telemetry/value/scalar.py
@@ -78,7 +78,15 @@ class ScalarValue(summarizable.SummarizableValue):
@staticmethod
def FromDict(value_dict, page_dict):
kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
- kwargs['value'] = value_dict['value']
+
+ # Infinity and NaN are left out of JSON for security reasons that do not
+ # apply to our use cases, so TBMv2 serializes them as strings,
+ # but TBMv1 doesn't support them.
+ if value_dict['value'] in ['Infinity', '-Infinity', 'NaN']:
+ kwargs['value'] = None
+ kwargs['none_value_reason'] = 'value was ' + value_dict['value']
+ else:
+ kwargs['value'] = value_dict['value']
if 'improvement_direction' in value_dict:
kwargs['improvement_direction'] = value_dict['improvement_direction']
« no previous file with comments | « telemetry/telemetry/value/common_value_helpers.py ('k') | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698