telemetry/telemetry/internal/results/page_test_results.py - Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/results/page_test_results.py

Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/results/html2_output_formatter.py ('k') | telemetry/telemetry/internal/results/results_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/results/page_test_results.py

diff --git a/telemetry/telemetry/internal/results/page_test_results.py b/telemetry/telemetry/internal/results/page_test_results.py

index 95a607fc50dcae45a745c5fcdd883dca6bd6da1b..aee0d95fc6ebb23d0d49d01b4649bc765f5343f6 100644

--- a/telemetry/telemetry/internal/results/page_test_results.py

+++ b/telemetry/telemetry/internal/results/page_test_results.py

@@ -63,6 +63,15 @@ class PageTestResults(object):

self._pages_to_profiling_files = collections.defaultdict(list)

self._pages_to_profiling_files_cloud_url = collections.defaultdict(list)

+ # You'd expect this to be a set(), but Values are dictionaries, which are

+ # unhashable. We could wrap Values with custom __eq/hash__, but we don't

+ # actually need set-ness in python.

+ self._value_set = []

+ @property

+ def value_set(self):

+ return self._value_set

def __copy__(self):

cls = self.__class__

result = cls.__new__(cls)