tracing/tracing/metrics/value_set.html - Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/value_set.html

Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Infinity/NaN in scalar.py -- this is why there should be only one implementation of Values Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« telemetry/telemetry/value/scalar.py ('K') | « tracing/tracing/metrics/system_health/responsiveness_metric.html ('k') | tracing/tracing/results2_template.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/value_set.html

diff --git a/tracing/tracing/metrics/value_set.html b/tracing/tracing/metrics/value_set.html

index 60d636146a8bae77347d802a3e336f4a21fd348d..b8fce24bb4e8b742ffb2a7d8fe5feeb7812a1f42 100644

--- a/tracing/tracing/metrics/value_set.html

+++ b/tracing/tracing/metrics/value_set.html

@@ -8,6 +8,7 @@ found in the LICENSE file.

+<link rel="import" href="/tracing/value/value.html">

'use strict';

@@ -30,6 +31,14 @@ tr.exportTo('tr.metrics', function() {

return tr.b.dictionaryValues(this.values_).map(cb, opt_this);

+ addValueDicts: function(dicts) {

+ dicts.forEach(function(dict) {

+ var value = tr.v.Value.fromDict(dict);

+ this.addValue(value);

+ // TODO(TBMv2.1): Patch up RelatedValueSets here.

+ }, this);

+ },

getValuesWithName: function(name) {

return tr.b.dictionaryValues(this.values_).filter(function(value) {

return value.name.indexOf(name) > -1;