Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1964593004: [runtime] relax DCHECK in Factory::NewFunction (Closed)

Created:
4 years, 7 months ago by caitp (gmail)
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] relax DCHECK in Factory::NewFunction Adds `strict_function_without_prototype_map` to DCHECK whitelist BUG= LOG=N R=littledan@chromium.org, jochen@chromium.org, jkummerow@chromium.org Committed: https://crrev.com/7d38a161a29dd9f7600d040c613d4afdc8be678b Cr-Commit-Position: refs/heads/master@{#36139}

Patch Set 1 #

Patch Set 2 : Removed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
caitp (gmail)
PTAL --- this is split out from the async functions runtime CL, with a short ...
4 years, 7 months ago (2016-05-10 02:22:36 UTC) #1
Jakob Kummerow
DCHECK relaxation LGTM. I'm not convinced of the usefulness of the test. The commit description ...
4 years, 7 months ago (2016-05-10 11:48:06 UTC) #2
caitp (gmail)
On 2016/05/10 11:48:06, Jakob wrote: > DCHECK relaxation LGTM. > > I'm not convinced of ...
4 years, 7 months ago (2016-05-10 12:00:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964593004/20001
4 years, 7 months ago (2016-05-10 12:03:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 12:31:37 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 12:32:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d38a161a29dd9f7600d040c613d4afdc8be678b
Cr-Commit-Position: refs/heads/master@{#36139}

Powered by Google App Engine
This is Rietveld 408576698