Enable running tryjobs with third_party/flac changes

Enable running tryjobs with third_party/flac changes

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300518

[hans, 2016-05-09 18:21:55]

hans@chromium.org changed reviewers:
+ tandrii@chromium.org

[hans, 2016-05-09 18:21:56]

As per tandrii's "PSA: Testing non-Chromium Patches on Chromium Trybots Is
Possible" email, trying to add third_party/flac to this file so I can run
tryjobs for changes in that directory.

[hans, 2016-05-09 18:24:01]

hans@chromium.org changed reviewers:
+ machenbach@chromium.org

[hans, 2016-05-09 18:24:01]

trandrii seems to be OOO

+machenbach, maybe you're familiar with this?

[tandrii(chromium), 2016-05-09 18:38:56]

On 2016/05/09 at 18:24:01, hans wrote:
> trandrii seems to be OOO
> 
> +machenbach, maybe you're familiar with this?

This is a LGTM, and you can commit but now.


Still, I think there is also another place to add got revision mapping, so that
you can chromium trybot executes properly compile and test without patch.

[hans, 2016-05-09 18:40:33]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:40:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964593002/1

[hans, 2016-05-09 18:43:06]

presubmit error:
google.appengine.api.appinfo_includes.IncludeFileNotFound: File gae_ts_mon
listed in includes directive of ./app.yaml could not be found.

help?

[commit-bot: I haz the power, 2016-05-09 18:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:45:52]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[hans, 2016-05-09 19:38:02]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-05-09 19:38:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964593002/1

[commit-bot: I haz the power, 2016-05-09 19:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 19:42:03]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[tandrii(chromium), 2016-05-10 02:21:17]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-05-10 02:21:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964593002/1

[commit-bot: I haz the power, 2016-05-10 02:25:15]

Description was changed from

==========
Enable running tryjobs with third_party/flac changes

BUG=none
==========

to

==========
Enable running tryjobs with third_party/flac changes

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300518
==========

[commit-bot: I haz the power, 2016-05-10 02:25:16]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300518

[Michael Achenbach, 2016-05-10 06:52:19]

On 2016/05/09 18:38:56, tandrii(chromium)-OOOmay11 wrote:
> On 2016/05/09 at 18:24:01, hans wrote:
> > trandrii seems to be OOO
> > 
> > +machenbach, maybe you're familiar with this?
> 
> This is a LGTM, and you can commit but now.
> 
> 
> Still, I think there is also another place to add got revision mapping, so
that
> you can chromium trybot executes properly compile and test without patch.

Yes. You might want an entry in the got_revision_mapping (a few lines above), so
that a trybot will use the same revision when retrying after failures. This
might lead to problems only for projects with frequent changes, though.

But we should get rid of this need entirely with a more generic solution that
uses the manifest output.

[hans, 2016-05-10 16:22:08]

My tryjobs didn't seem to work, see https://codereview.chromium.org/1961133002/

It's not a big deal, I can just land this one - but it would be cool if this
could work.

[tandrii(chromium), 2016-05-10 16:34:33]

On 2016/05/10 16:22:08, hans wrote:
> My tryjobs didn't seem to work, see
https://codereview.chromium.org/1961133002/
> 
> It's not a big deal, I can just land this one - but it would be cool if this
> could work.

ah your PROJECT field in codereview.settings is probably wrong:

https://chromium.googlesource.com/chromium/deps/flac/+/master/codereview.sett...
this CL expects it to be flac.

[hans, 2016-05-10 16:49:07]

I see.

Since we only touch that repository every other year, I'm not going to spend
time on it right now. It would be cool if all of this just worked automagically
one day :-)

[Michael Achenbach, 2016-05-11 07:05:15]

On 2016/05/10 16:49:07, hans wrote:
> I see.
> 
> Since we only touch that repository every other year, I'm not going to spend
> time on it right now. It would be cool if all of this just worked
automagically
> one day :-)

Added some more comments on the bug about this. http://crbug.com/491098