Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: third_party/WebKit/Source/core/input/TouchEventManager.h

Issue 1964523002: Fix clientX/Y properties of touch pointer events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TouchEventManager_h 5 #ifndef TouchEventManager_h
6 #define TouchEventManager_h 6 #define TouchEventManager_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/events/PointerEventFactory.h" 9 #include "core/events/PointerEventFactory.h"
10 #include "platform/UserGestureIndicator.h" 10 #include "platform/UserGestureIndicator.h"
(...skipping 19 matching lines...) Expand all
30 public: 30 public:
31 DEFINE_INLINE_TRACE() 31 DEFINE_INLINE_TRACE()
32 { 32 {
33 visitor->trace(touchNode); 33 visitor->trace(touchNode);
34 visitor->trace(targetFrame); 34 visitor->trace(targetFrame);
35 } 35 }
36 36
37 PlatformTouchPoint point; 37 PlatformTouchPoint point;
38 Member<Node> touchNode; 38 Member<Node> touchNode;
39 Member<LocalFrame> targetFrame; 39 Member<LocalFrame> targetFrame;
40 FloatPoint adjustedPagePoint; 40 FloatPoint clientPoint;
mustaq 2016/05/09 14:49:05 bokan@: "client" seems to be an overloaded term th
Navid Zolghadr 2016/05/09 17:01:43 bokan@, do you think framePoint is better instead
bokan 2016/05/09 17:17:47 Client and Frame are interchangeable. In terms of
41 FloatPoint contentPoint;
41 FloatSize adjustedRadius; 42 FloatSize adjustedRadius;
42 bool knownTarget; 43 bool knownTarget;
43 bool consumed; 44 bool consumed;
44 String region; 45 String region;
45 }; 46 };
46 47
47 explicit TouchEventManager(LocalFrame*); 48 explicit TouchEventManager(LocalFrame*);
48 ~TouchEventManager(); 49 ~TouchEventManager();
49 DECLARE_TRACE(); 50 DECLARE_TRACE();
50 51
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 // True if waiting on first touch move after a touch start. 94 // True if waiting on first touch move after a touch start.
94 bool m_waitingForFirstTouchMove; 95 bool m_waitingForFirstTouchMove;
95 96
96 }; 97 };
97 98
98 } // namespace blink 99 } // namespace blink
99 100
100 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::TouchEventManager::TouchInfo); 101 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::TouchEventManager::TouchInfo);
101 102
102 #endif // TouchEventManager_h 103 #endif // TouchEventManager_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698