third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe-expected.txt - Issue 1964523002: Fix clientX/Y properties of touch pointer events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe-expected.txt

Issue 1964523002: Fix clientX/Y properties of touch pointer events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe.html ('K') | « third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe.html ('k') | third_party/WebKit/Source/core/events/PointerEventFactory.h » ('j') | third_party/WebKit/Source/core/input/TouchEventManager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1

	2 This test verifies clientX/Y of pointer events inside iframe.

	3

	4 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	5

	6

	7 PASS successfullyParsed is true

	8

	9 TEST COMPLETE

	10 pointerdown of touch is recieved:

	11 clientX = 92
	mustaq 2016/05/09 18:08:34 It's not clear to me why (200,200) becomes (92,162 It's not clear to me why (200,200) becomes (92,162) and not (100,170). Any clue what causes the 8-pixel gaps? Padding may be? Please try to position the iframe using top/left, and set margin=padding=0. bokan 2016/05/09 18:13:08 Default body margin is 8px, I like to set body { m Show quoted text On 2016/05/09 18:08:34, mustaq wrote: > It's not clear to me why (200,200) becomes (92,162) and not (100,170). Any clue > what causes the 8-pixel gaps? Padding may be? Please try to position the iframe > using top/left, and set margin=padding=0. Default body margin is 8px, I like to set body { margin: 0px; } in tests for nice round numbers. Navid Zolghadr 2016/05/09 18:59:04 Done. Show quoted text On 2016/05/09 18:13:08, bokan wrote: > On 2016/05/09 18:08:34, mustaq wrote: > > It's not clear to me why (200,200) becomes (92,162) and not (100,170). Any > clue > > what causes the 8-pixel gaps? Padding may be? Please try to position the > iframe > > using top/left, and set margin=padding=0. > > Default body margin is 8px, I like to set body { margin: 0px; } in tests for > nice round numbers. Done.
	12 clientY = 162

	13 pointermove of touch is recieved:

	14 clientX = 92

	15 clientY = 162

	16 pointerup of touch is recieved:

	17 clientX = 92

	18 clientY = 162

	19

OLD	NEW