test/cctest/test-api.cc - Issue 1964433002: Expose IsConstructor to the C++ API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1964433002: Expose IsConstructor to the C++ API (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index b5cb2263b555539ac85f6134c075603bbeecb6e3..7714a560f3767cebe1e202a23e95ff0beac2be57 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -11101,6 +11101,7 @@ THREADED_TEST(FunctionRemovePrototype) {

Local<v8::FunctionTemplate> t1 = v8::FunctionTemplate::New(isolate);

t1->RemovePrototype();

Local<v8::Function> fun = t1->GetFunction(context.local()).ToLocalChecked();

+ CHECK(!fun->IsConstructor());

CHECK(context->Global()->Set(context.local(), v8_str("fun"), fun).FromJust());

CHECK(!CompileRun("'prototype' in fun")

->BooleanValue(context.local())

« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »