Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964433002: Expose IsConstructor to the C++ API (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose IsConstructor to the C++ API BUG=v8:4993 R=verwaest@chromium.org LOG=y Committed: https://crrev.com/acbbd59f29306a679e9e85b8ccfaa4eaaf969a6d Cr-Commit-Position: refs/heads/master@{#36107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-09 12:35:02 UTC) #1
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-09 13:12:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964433002/1
4 years, 7 months ago (2016-05-09 13:21:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 13:23:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:24:32 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/acbbd59f29306a679e9e85b8ccfaa4eaaf969a6d
Cr-Commit-Position: refs/heads/master@{#36107}

Powered by Google App Engine
This is Rietveld 408576698