Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2562)

Unified Diff: sdk/lib/_internal/compiler/implementation/enqueue.dart

Issue 196443004: Revert "Fix for queue closed crash" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/mirror_enqueuer_regression_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/enqueue.dart
diff --git a/sdk/lib/_internal/compiler/implementation/enqueue.dart b/sdk/lib/_internal/compiler/implementation/enqueue.dart
index 47150a055febcbc1177a5ad64f11e637e76a83cf..c700d5924fe2a0ed6950bdf43548d8307920e0ba 100644
--- a/sdk/lib/_internal/compiler/implementation/enqueue.dart
+++ b/sdk/lib/_internal/compiler/implementation/enqueue.dart
@@ -85,8 +85,7 @@ abstract class Enqueuer {
EnqueueTask task;
native.NativeEnqueuer nativeEnqueuer; // Set by EnqueueTask
- bool hasEnqueuedEverything = false;
- bool hasEnqueuedReflectiveStaticFields = false;
+ bool hasEnqueuedReflectiveElements = false;
Enqueuer(this.name, this.compiler, this.itemCompilationContextCreator);
@@ -360,7 +359,7 @@ abstract class Enqueuer {
}
void enqueueEverything() {
- if (hasEnqueuedEverything) return;
+ if (hasEnqueuedReflectiveElements) return;
compiler.log('Enqueuing everything');
task.ensureAllElementsByName();
for (Link link in task.allElementsByName.values) {
@@ -368,15 +367,14 @@ abstract class Enqueuer {
pretendElementWasUsed(element, compiler.globalDependencies);
}
}
- hasEnqueuedEverything = true;
- hasEnqueuedReflectiveStaticFields = true;
+ hasEnqueuedReflectiveElements = true;
}
/// Enqueue the static fields that have been marked as used by reflective
/// usage through `MirrorsUsed`.
void enqueueReflectiveStaticFields(Iterable<Element> elements) {
- if (hasEnqueuedReflectiveStaticFields) return;
- hasEnqueuedReflectiveStaticFields = true;
+ if (hasEnqueuedReflectiveElements) return;
+ hasEnqueuedReflectiveElements = true;
for (Element element in elements) {
pretendElementWasUsed(element, compiler.globalDependencies);
}
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/mirror_enqueuer_regression_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698