Apply viewport to dip scale to Graphics2D, Compositor

Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is off)
*Graphics2D's damage/clip rects should also be scaled accordingly.

BUG=596697, 599547, 591881
Committed: https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333
Cr-Commit-Position: refs/heads/master@{#393031}

[oshima, 2016-05-11 16:18:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 16:19:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964423003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964423003/1

[oshima, 2016-05-11 16:47:44]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-05-11 16:49:51]

Description was changed from

==========
Apply viewport to dip scale to Graphics2D, Compositor

BUG=
==========

to

==========
Apply viewport to dip scale to Graphics2D, Compositor

BUG=596697,599547,591881
==========

[oshima, 2016-05-11 16:50:37]

Description was changed from

==========
Apply viewport to dip scale to Graphics2D, Compositor

BUG=596697,599547,591881
==========

to

==========
Apply viewport to dip scale to Graphics2DHost, CompositorHost

* 


BUG=596697,599547,591881
==========

[oshima, 2016-05-11 16:50:52]

Description was changed from

==========
Apply viewport to dip scale to Graphics2DHost, CompositorHost

* 


BUG=596697,599547,591881
==========

to

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* 


BUG=596697,599547,591881
==========

[oshima, 2016-05-11 16:56:39]

Description was changed from

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* 


BUG=596697,599547,591881
==========

to

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates
when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is
off)
*Graphics2D's damage/clip rects should also be scaled accordingly. 

BUG=596697,599547,591881
==========

[oshima, 2016-05-11 16:56:39]

oshima@chromium.org changed reviewers:
+ bbudge@chromium.org

[oshima, 2016-05-11 17:10:33]

Patchset #3 (id:60001) has been deleted

[oshima, 2016-05-11 17:21:53]

Patchset #3 (id:80001) has been deleted

[oshima, 2016-05-11 17:21:58]

Patchset #2 (id:40001) has been deleted

[oshima, 2016-05-11 17:22:05]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 17:22:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964423003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964423003/100001

[bbudge, 2016-05-11 17:42:19]

I'm not sure how good our testing is. I assume you've done some manual testing.

LGTM

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_compositor_host.h (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_compositor_host.h:54: void
set_viewport_to_dip_scale(float viewport_to_dip_scale) {
DCHECK here for viewport_to_dip_scale != 0?

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_graphics_2d_host.cc (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_graphics_2d_host.cc:657: // pixels, so the damage
rects has to be scaled.
nit s/has/have

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_graphics_2d_host.h (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_graphics_2d_host.h:97: void
set_viewport_to_dip_scale(float viewport_to_dip_scale) {
DCHECK viewport_to_dip_scale?

[oshima, 2016-05-11 17:57:19]

Patchset #3 (id:120001) has been deleted

[oshima, 2016-05-11 18:18:15]

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_compositor_host.h (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_compositor_host.h:54: void
set_viewport_to_dip_scale(float viewport_to_dip_scale) {
On 2016/05/11 17:42:19, bbudge wrote:
> DCHECK here for viewport_to_dip_scale != 0?

Added DCHECK_LT(0, viewport_to_dip_scale);

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_graphics_2d_host.cc (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_graphics_2d_host.cc:657: // pixels, so the damage
rects has to be scaled.
On 2016/05/11 17:42:19, bbudge wrote:
> nit s/has/have

Done.

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_graphics_2d_host.h (right):

https://codereview.chromium.org/1964423003/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_graphics_2d_host.h:97: void
set_viewport_to_dip_scale(float viewport_to_dip_scale) {
On 2016/05/11 17:42:19, bbudge wrote:
> DCHECK viewport_to_dip_scale?

Added DCHECK_LT(0, viewport_to_dip_scale);

[oshima, 2016-05-11 18:18:52]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 18:21:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964423003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964423003/140001

[oshima, 2016-05-11 19:17:06]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2016-05-11 19:17:14]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-05-11 19:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/1964423003/#ps140001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-05-11 19:17:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964423003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964423003/140001

[commit-bot: I haz the power, 2016-05-11 19:44:10]

Description was changed from

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates
when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is
off)
*Graphics2D's damage/clip rects should also be scaled accordingly. 

BUG=596697,599547,591881
==========

to

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates
when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is
off)
*Graphics2D's damage/clip rects should also be scaled accordingly. 

BUG=596697,599547,591881
==========

[commit-bot: I haz the power, 2016-05-11 19:44:11]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-05-11 19:45:25]

Description was changed from

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates
when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is
off)
*Graphics2D's damage/clip rects should also be scaled accordingly. 

BUG=596697,599547,591881
==========

to

==========
Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates
when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is
off)
*Graphics2D's damage/clip rects should also be scaled accordingly.

BUG=596697,599547,591881

Committed: https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333
Cr-Commit-Position: refs/heads/master@{#393031}
==========

[commit-bot: I haz the power, 2016-05-11 19:45:27]

Patchset 3 (id:??) landed as
https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333
Cr-Commit-Position: refs/heads/master@{#393031}