Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1964403002: Retire leak-check.js. (Closed)

Created:
4 years, 7 months ago by kouhei (in TOK)
Modified:
4 years, 7 months ago
Reviewers:
haraken, hajimehoshi
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire leak-check.js. They are deprecated by "content_shell --run_layout_test --enable-leak-detection" BUG=None Committed: https://crrev.com/105b20843e8e75da6223777ed1efc0f9248b9ada Cr-Commit-Position: refs/heads/master@{#392889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -690 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/AccessibilityScrollbar-leak.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/AccessibilityScrollbar-leak-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/accessibility-controller-notificationlistener-leak-callback.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/accessibility-controller-notificationlistener-leak-callback-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/axobjectcache-leaks-node.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/axobjectcache-leaks-node-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/context-menu-leak-document.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/context-menu-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/leak-document-with-selection-inside.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/leak-document-with-selection-inside-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-queue-testrunner-leak-request.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-queue-testrunner-leak-request-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/background-image-leak.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/background-image-leak-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/custom/leaks.html View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/custom/leaks-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/document-softleak-mouse-navigation.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/document-softleak-mouse-navigation-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/event-sender-context-click-leak-document.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/event-sender-context-click-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-leak-document.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-leaks-on-multiple-send.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-leaks-on-multiple-send-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/resources/leak-check.js View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGListPropertyTearOff-leaks.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGListPropertyTearOff-leaks-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/svg-font-face-leak-document.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/svg-font-face-leak-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kouhei (in TOK)
?
4 years, 7 months ago (2016-05-11 08:23:09 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-11 08:25:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964403002/1
4 years, 7 months ago (2016-05-11 08:25:32 UTC) #5
hajimehoshi
lgtm
4 years, 7 months ago (2016-05-11 08:29:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 09:55:48 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 09:57:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/105b20843e8e75da6223777ed1efc0f9248b9ada
Cr-Commit-Position: refs/heads/master@{#392889}

Powered by Google App Engine
This is Rietveld 408576698