Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 196433003: Fix git_nav_downstream.py when origin/master is checked out. (Closed)

Created:
6 years, 9 months ago by iannucci
Modified:
6 years, 9 months ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Fix git_nav_downstream.py when origin/master is checked out. Also fix missing copyright notices. R=agable@chromium.org BUG=261738 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256777

Patch Set 1 #

Patch Set 2 : Also add a * on origin/master when its checked out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M git_map.py View 1 chunk +4 lines, -0 lines 0 comments Download
M git_map_branches.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M git_nav_downstream.py View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
iannucci
6 years, 9 months ago (2014-03-12 03:13:17 UTC) #1
agable
lgtm
6 years, 9 months ago (2014-03-13 00:48:41 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 9 months ago (2014-03-13 02:11:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/196433003/20001
6 years, 9 months ago (2014-03-13 02:11:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 02:14:40 UTC) #5
commit-bot: I haz the power
Presubmit check for 196433003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 9 months ago (2014-03-13 02:14:40 UTC) #6
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 9 months ago (2014-03-13 07:46:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/196433003/20001
6 years, 9 months ago (2014-03-13 07:46:21 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 07:47:51 UTC) #9
Message was sent while issue was closed.
Change committed as 256777

Powered by Google App Engine
This is Rietveld 408576698