Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: media/cast/transport/pacing/paced_sender.h

Issue 196433002: Cast: Log sender side packet events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/pacing/paced_sender.h
diff --git a/media/cast/transport/pacing/paced_sender.h b/media/cast/transport/pacing/paced_sender.h
index 69a6079e096ee23855da2b626f8b21599273e19b..36deb029c87b7ef6f905a43be3d90c3ef96a6f90 100644
--- a/media/cast/transport/pacing/paced_sender.h
+++ b/media/cast/transport/pacing/paced_sender.h
@@ -21,6 +21,9 @@
namespace media {
namespace cast {
+
+class LoggingImpl;
+
namespace transport {
// We have this pure virtual class to enable mocking.
@@ -44,11 +47,16 @@ class PacedSender : public PacedPacketSender,
// testing.
PacedSender(
base::TickClock* clock,
+ LoggingImpl* logging,
PacketSender* external_transport,
const scoped_refptr<base::SingleThreadTaskRunner>& transport_task_runner);
virtual ~PacedSender();
+ // These must be called before non-RTCP packets are sent.
+ void RegisterAudioSsrc(uint32 audio_ssrc);
+ void RegisterVideoSsrc(uint32 video_ssrc);
+
// PacedPacketSender implementation.
virtual bool SendPackets(const PacketList& packets) OVERRIDE;
@@ -66,17 +74,22 @@ class PacedSender : public PacedPacketSender,
private:
bool SendPacketsToTransport(const PacketList& packets,
- PacketList* packets_not_sent);
+ PacketList* packets_not_sent,
+ bool retransmit);
// Actually sends the packets to the transport.
bool TransmitPackets(const PacketList& packets);
void SendStoredPackets();
void UpdateBurstSize(size_t num_of_packets);
- // Not owned by this class.
- base::TickClock* const clock_;
- PacketSender* transport_; // Not owned by this class.
+ void LogPacketEvent(const Packet& packet, bool retransmit);
+
+ base::TickClock* const clock_; // Not owned by this class.
+ LoggingImpl* const logging_; // Not owned by this class.
+ PacketSender* transport_; // Not owned by this class.
scoped_refptr<base::SingleThreadTaskRunner> transport_task_runner_;
+ uint32 audio_ssrc_;
+ uint32 video_ssrc_;
size_t burst_size_;
size_t packets_sent_in_burst_;
base::TimeTicks time_last_process_;

Powered by Google App Engine
This is Rietveld 408576698