Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1964303002: Change GN defaults for toolchains for CrOS. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
CC:
chromium-reviews, stevenjb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GN defaults for toolchains for CrOS. Previously we would attempt to use clang for the host toolchain by default regardless of what is_clang was set to. However, we really only want to use clang for the host toolchain on Android; on CrOS, we typically don't have clang for either host or target, and so if is_clang is false for the target it should probably also be false for the host toolchain. This CL changes the defaults accordingly. It also adds a comment to the sysroot variables to make it clearer that target_sysroot and use_sysroot can both be used; this is needed so that you can set target_sysroot= for the target and then set use_sysroot=false for the other toolchains (so that the host toolchain doesn't attempt to use a sysroot it can't use). R=brettw@chromium.org, jochen@chromium.org BUG=608596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Dirk Pranke
4 years, 7 months ago (2016-05-11 02:04:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-11 08:56:19 UTC) #2
brettw
lgtm
4 years, 7 months ago (2016-05-11 20:29:10 UTC) #3
Dirk Pranke
4 years, 7 months ago (2016-05-17 21:52:35 UTC) #5
Message was sent while issue was closed.
Abandoning this in favor of https://codereview.chromium.org/1983613002/ - we
need the more general approach in that CL, I think.

Powered by Google App Engine
This is Rietveld 408576698