Chromium Code Reviews
DescriptionChange GN defaults for toolchains for CrOS.
Previously we would attempt to use clang for the host toolchain
by default regardless of what is_clang was set to. However,
we really only want to use clang for the host toolchain on Android;
on CrOS, we typically don't have clang for either host or target,
and so if is_clang is false for the target it should probably also
be false for the host toolchain.
This CL changes the defaults accordingly.
It also adds a comment to the sysroot variables to make it clearer
that target_sysroot and use_sysroot can both be used; this is
needed so that you can set target_sysroot= for the target and then
set use_sysroot=false for the other toolchains (so that the host
toolchain doesn't attempt to use a sysroot it can't use).
R=brettw@chromium.org, jochen@chromium.org
BUG=608596
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||