Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #import "ui/views/cocoa/bridged_native_widget.h" | 5 #import "ui/views/cocoa/bridged_native_widget.h" |
| 6 | 6 |
| 7 #import <objc/runtime.h> | 7 #import <objc/runtime.h> |
| 8 #include <stddef.h> | 8 #include <stddef.h> |
| 9 #include <stdint.h> | 9 #include <stdint.h> |
| 10 | 10 |
| 11 #include "base/logging.h" | 11 #include "base/logging.h" |
| 12 #import "base/mac/foundation_util.h" | 12 #import "base/mac/foundation_util.h" |
| 13 #include "base/mac/mac_util.h" | 13 #include "base/mac/mac_util.h" |
| 14 #import "base/mac/sdk_forward_declarations.h" | 14 #import "base/mac/sdk_forward_declarations.h" |
| 15 #include "base/threading/thread_task_runner_handle.h" | 15 #include "base/threading/thread_task_runner_handle.h" |
| 16 #include "ui/accelerated_widget_mac/window_resize_helper_mac.h" | 16 #include "ui/accelerated_widget_mac/window_resize_helper_mac.h" |
| 17 #import "ui/base/cocoa/constrained_window/constrained_window_animation.h" | 17 #import "ui/base/cocoa/constrained_window/constrained_window_animation.h" |
| 18 #include "ui/base/hit_test.h" | 18 #include "ui/base/hit_test.h" |
| 19 #include "ui/base/ime/input_method.h" | 19 #include "ui/base/ime/input_method.h" |
| 20 #include "ui/base/ime/input_method_factory.h" | 20 #include "ui/base/ime/input_method_factory.h" |
| 21 #include "ui/display/display.h" | 21 #include "ui/display/display.h" |
| 22 #include "ui/display/screen.h" | 22 #include "ui/display/screen.h" |
| 23 #include "ui/gfx/geometry/dip_util.h" | 23 #include "ui/gfx/geometry/dip_util.h" |
| 24 #import "ui/gfx/mac/coordinate_conversion.h" | 24 #import "ui/gfx/mac/coordinate_conversion.h" |
| 25 #import "ui/gfx/mac/nswindow_frame_controls.h" | 25 #import "ui/gfx/mac/nswindow_frame_controls.h" |
| 26 #import "ui/views/cocoa/bridged_content_view.h" | 26 #import "ui/views/cocoa/bridged_content_view.h" |
| 27 #import "ui/views/cocoa/drag_drop_client_mac.h" | |
| 27 #import "ui/views/cocoa/cocoa_mouse_capture.h" | 28 #import "ui/views/cocoa/cocoa_mouse_capture.h" |
| 28 #include "ui/views/cocoa/tooltip_manager_mac.h" | 29 #include "ui/views/cocoa/tooltip_manager_mac.h" |
| 29 #import "ui/views/cocoa/views_nswindow_delegate.h" | 30 #import "ui/views/cocoa/views_nswindow_delegate.h" |
| 30 #import "ui/views/cocoa/widget_owner_nswindow_adapter.h" | 31 #import "ui/views/cocoa/widget_owner_nswindow_adapter.h" |
| 31 #include "ui/views/view.h" | 32 #include "ui/views/view.h" |
| 32 #include "ui/views/views_delegate.h" | 33 #include "ui/views/views_delegate.h" |
| 33 #include "ui/views/widget/native_widget_mac.h" | 34 #include "ui/views/widget/native_widget_mac.h" |
| 34 #include "ui/views/widget/widget.h" | 35 #include "ui/views/widget/widget.h" |
| 35 #include "ui/views/widget/widget_aura_utils.h" | 36 #include "ui/views/widget/widget_aura_utils.h" |
| 36 #include "ui/views/widget/widget_delegate.h" | 37 #include "ui/views/widget/widget_delegate.h" |
| (...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 511 animate:NO]; | 512 animate:NO]; |
| 512 } | 513 } |
| 513 | 514 |
| 514 void BridgedNativeWidget::SetRootView(views::View* view) { | 515 void BridgedNativeWidget::SetRootView(views::View* view) { |
| 515 if (view == [bridged_view_ hostedView]) | 516 if (view == [bridged_view_ hostedView]) |
| 516 return; | 517 return; |
| 517 | 518 |
| 518 // If this is ever false, the compositor will need to be properly torn down | 519 // If this is ever false, the compositor will need to be properly torn down |
| 519 // and replaced, pointing at the new view. | 520 // and replaced, pointing at the new view. |
| 520 DCHECK(!view || !compositor_widget_); | 521 DCHECK(!view || !compositor_widget_); |
| 521 | 522 |
|
tapted
2016/06/01 01:57:01
hm - I think we do still need the drag_drop_client
spqchan
2016/06/01 19:09:28
Done.
| |
| 522 [bridged_view_ clearView]; | 523 [bridged_view_ clearView]; |
| 523 bridged_view_.reset(); | 524 bridged_view_.reset(); |
| 524 // Note that there can still be references to the old |bridged_view_| | 525 // Note that there can still be references to the old |bridged_view_| |
| 525 // floating around in Cocoa libraries at this point. However, references to | 526 // floating around in Cocoa libraries at this point. However, references to |
| 526 // the old views::View will be gone, so any method calls will become no-ops. | 527 // the old views::View will be gone, so any method calls will become no-ops. |
| 527 | 528 |
| 528 if (view) { | 529 if (view) { |
| 529 bridged_view_.reset([[BridgedContentView alloc] initWithView:view]); | 530 bridged_view_.reset([[BridgedContentView alloc] initWithView:view]); |
| 531 drag_drop_client_.reset(new DragDropClientMac(this, view)); | |
| 532 | |
| 530 // Objective C initializers can return nil. However, if |view| is non-NULL | 533 // Objective C initializers can return nil. However, if |view| is non-NULL |
| 531 // this should be treated as an error and caught early. | 534 // this should be treated as an error and caught early. |
| 532 CHECK(bridged_view_); | 535 CHECK(bridged_view_); |
| 533 } | 536 } |
| 534 [window_ setContentView:bridged_view_]; | 537 [window_ setContentView:bridged_view_]; |
| 535 } | 538 } |
| 536 | 539 |
| 537 void BridgedNativeWidget::SetVisibilityState(WindowVisibilityState new_state) { | 540 void BridgedNativeWidget::SetVisibilityState(WindowVisibilityState new_state) { |
| 538 // Ensure that: | 541 // Ensure that: |
| 539 // - A window with an invisible parent is not made visible. | 542 // - A window with an invisible parent is not made visible. |
| (...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1303 [bridged_view_ setMouseDownCanMoveWindow:draggable]; | 1306 [bridged_view_ setMouseDownCanMoveWindow:draggable]; |
| 1304 // AppKit will not update its cache of mouseDownCanMoveWindow unless something | 1307 // AppKit will not update its cache of mouseDownCanMoveWindow unless something |
| 1305 // changes. Previously we tried adding an NSView and removing it, but for some | 1308 // changes. Previously we tried adding an NSView and removing it, but for some |
| 1306 // reason it required reposting the mouse-down event, and didn't always work. | 1309 // reason it required reposting the mouse-down event, and didn't always work. |
| 1307 // Calling the below seems to be an effective solution. | 1310 // Calling the below seems to be an effective solution. |
| 1308 [window_ setMovableByWindowBackground:NO]; | 1311 [window_ setMovableByWindowBackground:NO]; |
| 1309 [window_ setMovableByWindowBackground:YES]; | 1312 [window_ setMovableByWindowBackground:YES]; |
| 1310 } | 1313 } |
| 1311 | 1314 |
| 1312 } // namespace views | 1315 } // namespace views |
| OLD | NEW |