content/common/host_zoom_level.mojom - Issue 1964273002: Add FrameHost mojo service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/host_zoom_level.mojom

Issue 1964273002: Add FrameHost mojo service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android-2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module url.mojom;	5 module content.mojom;

6	6

7 import "url/mojo/origin.mojom";

8 import "url/mojo/url.mojom";	7 import "url/mojo/url.mojom";

9	8

10 interface UrlTest {	9 interface HostZoomLevel {

11 [Sync]	10 GetZoomLevel(url.mojom.Url url, int32 render_view_id)
	jam 2016/05/16 18:28:32 we eventually want to get rid of routing IDs. Ca we eventually want to get rid of routing IDs. Can we make this service per-frame instead of per-process? then we don't need to pass routing IDs. wjmaclean 2016/05/16 18:59:53 Sorry, just noticed this comment. The main concer Show quoted text On 2016/05/16 18:28:32, jam wrote: > we eventually want to get rid of routing IDs. > > Can we make this service per-frame instead of per-process? then we don't need to > pass routing IDs. Sorry, just noticed this comment. The main concern here I think is whether the zoom level is based on the URL as stored in the HostZoomMap, or to a view/page in which the normal zoom level is overriden (TemporaryZoomLevel). In either case I think it's fine to think of the zoom level as being tied to the frame, since any frame will be tied to a particular view from which a zoom level can be found. If the frame is top-level, then its preferred zoom level is dictated by that of the main frame anyways. scottmg 2016/05/16 22:54:56 OK, thanks. Moved to the frame. Show quoted text On 2016/05/16 18:59:53, wjmaclean wrote: > On 2016/05/16 18:28:32, jam wrote: > > we eventually want to get rid of routing IDs. > > > > Can we make this service per-frame instead of per-process? then we don't need > to > > pass routing IDs. > > Sorry, just noticed this comment. > > The main concern here I think is whether the zoom level is based on the URL as > stored in the HostZoomMap, or to a view/page in which the normal zoom level is > overriden (TemporaryZoomLevel). In either case I think it's fine to think of the > zoom level as being tied to the frame, since any frame will be tied to a > particular view from which a zoom level can be found. If the frame is top-level, > then its preferred zoom level is dictated by that of the main frame anyways. OK, thanks. Moved to the frame.
12 BounceUrl(Url in) => (Url out);	11 => (url.mojom.Url url, double zoom_level);

13

14 [Sync]

15 BounceOrigin(Origin in) => (Origin out);

16 };	12 };

OLD	NEW

« content/browser/loader/async_resource_handler.cc ('K') | « content/common/BUILD.gn ('k') | content/common/view_messages.h » ('j') | content/renderer/render_frame_impl.h » ('J')