Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1964243005:
Revert "MD Settings: Expanding cards should not overlap header" (Closed)
|
Created:
4 years, 7 months ago by michaelpg Modified:
4 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, dschuyler Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert "MD Settings: Expanding cards should not overlap header"
This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a.
The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs.
BUG=611146
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/a949965662f9ed28175288034aa45a3b4649e036
Cr-Commit-Position: refs/heads/master@{#393122}
Patch Set 1 #
Total comments: 2
Patch Set 2 : partial revert #Messages
Total messages: 14 (7 generated)
Description was changed from ========== Revert "MD Settings: Expanding cards should not overlap header" This reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org ========== to ========== Revert "MD Settings: Expanding cards should not overlap header" This reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Revert "MD Settings: Expanding cards should not overlap header" This reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Revert "MD Settings: Expanding cards should not overlap header" This reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
https://codereview.chromium.org/1964243005/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_ui/settings_ui.html (left): https://codereview.chromium.org/1964243005/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_ui/settings_ui.html:136: }; can you leave this?
lgtm
https://codereview.chromium.org/1964243005/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_ui/settings_ui.html (left): https://codereview.chromium.org/1964243005/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_ui/settings_ui.html:136: }; On 2016/05/11 22:45:49, Dan Beam wrote: > can you leave this? Done.
Description was changed from ========== Revert "MD Settings: Expanding cards should not overlap header" This reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Revert "MD Settings: Expanding cards should not overlap header" This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/1964243005/#ps20001 (title: "partial revert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964243005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964243005/20001
Message was sent while issue was closed.
Description was changed from ========== Revert "MD Settings: Expanding cards should not overlap header" This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Revert "MD Settings: Expanding cards should not overlap header" This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Revert "MD Settings: Expanding cards should not overlap header" This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Revert "MD Settings: Expanding cards should not overlap header" This partially reverts commit 57b3eadebbb95a01dc932c14654032eab5b8013a. The original CL, crrev.com/1966543002/, worked as intended, but made dialogs not usable. Since the original CL addressed a minor visual glitch, revert it for now so we can continue developing dialogs. BUG=611146 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a949965662f9ed28175288034aa45a3b4649e036 Cr-Commit-Position: refs/heads/master@{#393122} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a949965662f9ed28175288034aa45a3b4649e036 Cr-Commit-Position: refs/heads/master@{#393122} |
