Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1964243002: Reland: Test dismissing CVC prompt for PaymentRequest (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Test dismissing CVC prompt for PaymentRequest This is an integration test for PaymentRequest that performs the following steps: 1) Launch PaymentRequest UI. 2) Click "Pay" in PaymentRequest UI. 3) Click "Cancel" in CVC prompt. 4) Click "OK" to dismiss the result dialog. Originally landed in: https://crrev.com/ae3e707b1e771518538a8f12de5cdf88e0aef865 Consequently reverted in: https://crrev.com/ce49849aadf7c4378c99cc4da45b3ff7671cdde8 due to a StrictMode violation. Investigations into StrictMode errors seems to point to unclosed Mojo pipe on shutdown. As a result, this patch adds explicit Mojo pipe closing to the Java implementation of PaymentRequest service. BUG=608223 Committed: https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e Cr-Commit-Position: refs/heads/master@{#392789}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 7 months ago (2016-05-10 23:18:33 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-10 23:24:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964243002/1
4 years, 7 months ago (2016-05-10 23:38:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 00:40:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e Cr-Commit-Position: refs/heads/master@{#392789}
4 years, 7 months ago (2016-05-11 00:42:16 UTC) #8
please use gerrit instead
4 years, 7 months ago (2016-05-11 02:52:55 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1971603003/ by rouslan@chromium.org.

The reason for reverting is: Fails on Android GN with Strict Mode violation.

https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34219

.

Powered by Google App Engine
This is Rietveld 408576698