Move SoftwareFrameData overflow checks to the IPC code.

content/common/cc_messages_unittest.cc

Index: content/common/cc_messages_unittest.cc
diff --git a/content/common/cc_messages_unittest.cc b/content/common/cc_messages_unittest.cc
index 7711c23f38c8575feb161326bf6c1ad414f30eaa..51232b40bb9932efd7ab32179520f9543f60ff87 100644
--- a/content/common/cc_messages_unittest.cc
+++ b/content/common/cc_messages_unittest.cc
@@ -9,11 +9,16 @@
 #include <algorithm>
 
 #include "cc/output/compositor_frame.h"
+#include "content/public/common/common_param_traits.h"
 #include "ipc/ipc_message.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/khronos/GLES2/gl2ext.h"
 #include "third_party/skia/include/effects/SkBlurImageFilter.h"
 
+#if defined(OS_POSIX)
+#include "base/file_descriptor_posix.h"
+#endif
+
 using cc::CheckerboardDrawQuad;
 using cc::DelegatedFrameData;
 using cc::DebugBorderDrawQuad;
@@ -26,6 +31,7 @@ using cc::RenderPass;
 using cc::RenderPassDrawQuad;
 using cc::ResourceProvider;
 using cc::SharedQuadState;
+using cc::SoftwareFrameData;
 using cc::SolidColorDrawQuad;
 using cc::SurfaceDrawQuad;
 using cc::TextureDrawQuad;
@@ -742,5 +748,78 @@ TEST_F(CCMessagesTest, LargestQuadType) {
   EXPECT_EQ(sizeof(RenderPassDrawQuad), largest);
 }
 
+TEST_F(CCMessagesTest, SoftwareFrameData) {
+  cc::SoftwareFrameData frame_in;
+  frame_in.id = 3;
+  frame_in.size = gfx::Size(40, 20);
+  frame_in.damage_rect = gfx::Rect(5, 18, 31, 44);
+#if defined(OS_WIN)
+  frame_in.handle = reinterpret_cast<base::SharedMemoryHandle>(23);
+#elif defined(OS_POSIX)
+  frame_in.handle = base::FileDescriptor(23, true);
+#endif
+
+  // Write the frame.
+  IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
+  IPC::ParamTraits<cc::SoftwareFrameData>::Write(&msg, frame_in);
+
+  // Read the frame.
+  cc::SoftwareFrameData frame_out;
+  PickleIterator iter(msg);
+  EXPECT_TRUE(
+      IPC::ParamTraits<SoftwareFrameData>::Read(&msg, &iter, &frame_out));
+  EXPECT_EQ(frame_in.id, frame_out.id);
+  EXPECT_EQ(frame_in.size.ToString(), frame_out.size.ToString());
+  EXPECT_EQ(frame_in.damage_rect.ToString(), frame_out.damage_rect.ToString());
+  EXPECT_EQ(frame_in.handle, frame_out.handle);
+}
+
+TEST_F(CCMessagesTest, SoftwareFrameDataMaxInt) {
+  SoftwareFrameData frame_in;
+  frame_in.id = 3;
+  frame_in.size = gfx::Size(40, 20);
+  frame_in.damage_rect = gfx::Rect(5, 18, 31, 44);
+#if defined(OS_WIN)
+  frame_in.handle = reinterpret_cast<base::SharedMemoryHandle>(23);
+#elif defined(OS_POSIX)
+  frame_in.handle = base::FileDescriptor(23, true);
+#endif
+
+  // Write the SoftwareFrameData by hand, make sure it works.
+  {
+    IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
+    IPC::WriteParam(&msg, frame_in.id);
+    IPC::WriteParam(&msg, frame_in.size);
+    IPC::WriteParam(&msg, frame_in.damage_rect);
+    IPC::WriteParam(&msg, frame_in.handle);
+    SoftwareFrameData frame_out;
+    PickleIterator iter(msg);
+    EXPECT_TRUE(
+        IPC::ParamTraits<SoftwareFrameData>::Read(&msg, &iter, &frame_out));
+  }
+
+  // The size of the frame may overflow when multiplied together.
+  int max = std::numeric_limits<int>::max();
+  frame_in.size = gfx::Size(max, max);
+
+  // If size_t is larger than int, then int*int*4 can always fit in size_t.
+  bool expect_read = sizeof(size_t) >= sizeof(int) * 2;
+
+  // Write the SoftwareFrameData with the MaxInt size, if it causes overflow it
+  // should fail.
+  {
+    IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
+    IPC::WriteParam(&msg, frame_in.id);
+    IPC::WriteParam(&msg, frame_in.size);
+    IPC::WriteParam(&msg, frame_in.damage_rect);
+    IPC::WriteParam(&msg, frame_in.handle);
+    SoftwareFrameData frame_out;
+    PickleIterator iter(msg);
+    EXPECT_EQ(
+        expect_read,
+        IPC::ParamTraits<SoftwareFrameData>::Read(&msg, &iter, &frame_out));
+  }
+}
+
 }  // namespace
 }  // namespace content