Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 196423009: Swich to the new CpuProfiler api that returns non-const CpuProfile (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Visibility:
Public.

Description

Swich to the new CpuProfiler api that returns non-const CpuProfile BUG=v8:3213 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/bindings/v8/ScriptProfiler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/ScriptProfile.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 9 months ago (2014-03-14 07:40:07 UTC) #1
alph
lgtm
6 years, 9 months ago (2014-03-14 07:57:42 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-18 07:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/196423009/1
6 years, 9 months ago (2014-03-18 07:21:26 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 08:03:13 UTC) #5
Message was sent while issue was closed.
Change committed as 169427

Powered by Google App Engine
This is Rietveld 408576698