Issue 196423008: android: Make javac rules depend on java files too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196423008: android: Make javac rules depend on java files too. (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
Miguel Garcia, cjhopman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

android: Make javac rules depend on java files too. Fixes regression from r256667, which made javac only rerun when the list of java files changed, not when a java file itself was touched :-/ BUG=177552 TEST=touch java file, rebuild. apk gets updated. R=miguelg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256842

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	build/java.gypi	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
	M	build/java_apk.gypi	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Miguel Garcia

Tested it both downstream and upstream and they are both working with the patch

6 years, 9 months ago (2014-03-13 15:45:59 UTC) #2

Nico

6 years, 9 months ago (2014-03-13 15:47:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r256842 (tree was closed).