Fix asan build of gdb_rsp_unittest.

Fix asan build of gdb_rsp_unittest.

BUG=610748

[krasin, 2016-05-11 03:08:42]

krasin@google.com changed reviewers:
+ mseaborn@chromium.org

[krasin, 2016-05-11 03:08:43]

Hi Mark,

fixing this BUILD.gn file per Tom's request here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/EvDzuMBAaIk

[krasin, 2016-05-11 03:13:10]

As an observation, we have ~80 targets explicitly adding this dependency:
https://code.google.com/p/chromium/codesearch#search/&q=build/config/sanitize...

I guess the reason it's not default, because there're even more targets without
them.

[Mark Seaborn, 2016-05-11 19:24:05]

Is there a way to add "//build/config/sanitizers:deps" implicitly to all
executable targets in GN?  That would be a more general fix.

[krasin, 2016-05-11 19:39:23]

On 2016/05/11 19:24:05, Mark Seaborn wrote:
> Is there a way to add "//build/config/sanitizers:deps" implicitly to all
> executable targets in GN?  That would be a more general fix.

Yes, there's a way: add a line into src/build/config/BUILDCONFIG.gn. In fact,
this dependency is already added to all components.
It might be tricky to execute such cleanup, though, as some executables might
not want it, and while it's possible to remove a dependency from a target, I
currently don't see a good way to find the list of such executables.

[krasin, 2016-05-11 19:40:01]

I will try to ask around for a context. I am really not sure why the things are
like this.

[Mark Seaborn, 2016-05-11 20:02:09]

On 11 May 2016 at 12:39, <krasin@google.com> wrote:

> On 2016/05/11 19:24:05, Mark Seaborn wrote:
> > Is there a way to add "//build/config/sanitizers:deps" implicitly to all
> > executable targets in GN? That would be a more general fix.
>
> Yes, there's a way: add a line into src/build/config/BUILDCONFIG.gn. In
> fact,
> this dependency is already added to all components.
> It might be tricky to execute such cleanup, though, as some executables
> might
> not want it, and while it's possible to remove a dependency from a target,
> I
> currently don't see a good way to find the list of such executables.
>

Why would some executables not want it?  Are there any executables for
which sanitizers would be disabled?

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.