base/traced_object.h - Issue 19642005: Make TracedValue lower overhead.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/traced_object.h

Issue 19642005: Make TracedValue lower overhead. Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed lint errors. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_TRACED_OBJECT_H_

	6 #define BASE_TRACED_OBJECT_H_

	7

	8 #include "base/trace_event_value.h"

	9

	10 namespace base {

	11

	12 class TracedValue;

	13

	14 class BASE_EXPORT TracedObject {

	15 public:

	16 virtual ~TracedObject() {}
	rterrazas 2013/07/21 22:23:49 This is the interface I mentioned, implementing th This is the interface I mentioned, implementing this would allow us to push objects of whatever type we want into the pickle, and it would separate the core TracedValue code from classes that need to be traced through it. Is this a pattern we'd like to adopt?. dsinclair 2013/07/23 14:56:29 As above, I don't think this is needed. Is there a Show quoted text On 2013/07/21 22:23:49, rterrazas wrote: > This is the interface I mentioned, implementing this would allow us to push > objects of whatever type we want into the pickle, and it would separate the core > TracedValue code from classes that need to be traced through it. > > Is this a pattern we'd like to adopt?. As above, I don't think this is needed. Is there a specific usecase where we need this over just passing TracedValue's into Push?
	17 virtual void PushInto(base::TracedValue* traced_value) const {}

	18 };

	19

	20 } // namespace base

	21

	22 #endif // BASE_TRACED_OBJECT_H_

	23

OLD	NEW