Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1964143005: Revert of Clean up IPAddress::ToString related TODO. (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up IPAddress::ToString related TODO. (patchset #1 id:1 of https://codereview.chromium.org/1957753002/ ) Reason for revert: Speculatively reverting because this may have broken a Dr. Memory bot: First breaking build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4845 Original issue's description: > Clean up IPAddress::ToString related TODO. > > Committed: https://crrev.com/b8db9ba385ae3a2823a5dcc48acaf889c0f650f3 > Cr-Commit-Position: refs/heads/master@{#392670} TBR=eroman@chromium.org,sergeyu@chromium.org,martijn@martijnc.be # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3b09400275a762dddbf6c1a3b0603ee554957d46 Cr-Commit-Position: refs/heads/master@{#392962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M net/quic/p2p/quic_p2p_session.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
Created Revert of Clean up IPAddress::ToString related TODO.
4 years, 7 months ago (2016-05-11 17:08:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964143005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964143005/1
4 years, 7 months ago (2016-05-11 17:09:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 17:09:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b09400275a762dddbf6c1a3b0603ee554957d46 Cr-Commit-Position: refs/heads/master@{#392962}
4 years, 7 months ago (2016-05-11 17:11:19 UTC) #6
tommycli
4 years, 7 months ago (2016-05-12 20:43:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1969253003/ by tommycli@chromium.org.

The reason for reverting is: Reverting this patch did not fix the issue. Sorry..

Powered by Google App Engine
This is Rietveld 408576698