Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964143004: Fix live bytes counter in large object space after right trimming. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix live bytes counter in large object space after right trimming. BUG=chromium:609761 LOG=NO Committed: https://crrev.com/12fa3fff651181098956fa46bac7c3ac1d1424ab Cr-Commit-Position: refs/heads/master@{#36183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/heap/heap.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
ptal
4 years, 7 months ago (2016-05-11 13:51:05 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 7 months ago (2016-05-11 15:57:57 UTC) #4
Michael Lippautz
lgtm
4 years, 7 months ago (2016-05-11 15:59:22 UTC) #5
Michael Lippautz
On 2016/05/11 15:59:22, Michael Lippautz wrote: > lgtm thanks for also adding a test!
4 years, 7 months ago (2016-05-11 15:59:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964143004/1
4 years, 7 months ago (2016-05-11 16:00:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 16:56:43 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 16:57:58 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/12fa3fff651181098956fa46bac7c3ac1d1424ab
Cr-Commit-Position: refs/heads/master@{#36183}

Powered by Google App Engine
This is Rietveld 408576698