Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1964133002: Convert set zoom calls to go through RenderView. (Closed)

Created:
4 years, 7 months ago by wjmaclean
Modified:
4 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert set zoom calls to go through RenderView. Refactor to force all SetZoomLevel calls from RenderFrameImpl to go through the RenderView. BUG=none Committed: https://crrev.com/7d739009588058584119d03613a940c12b6e6ba5 Cr-Commit-Position: refs/heads/master@{#393236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964133002/1
4 years, 7 months ago (2016-05-10 19:48:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 20:44:38 UTC) #4
wjmaclean
creis@ - Here's a CL to convert the other two calls in RenderFrameImpl ... shall ...
4 years, 7 months ago (2016-05-10 20:46:30 UTC) #7
Charlie Reis
LGTM, but let's not land this until a different Canary than your previous CL, so ...
4 years, 7 months ago (2016-05-10 23:10:18 UTC) #8
wjmaclean
On 2016/05/10 23:10:18, Charlie Reis wrote: > LGTM, but let's not land this until a ...
4 years, 7 months ago (2016-05-10 23:16:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964133002/1
4 years, 7 months ago (2016-05-12 12:14:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 13:12:44 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 13:13:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d739009588058584119d03613a940c12b6e6ba5
Cr-Commit-Position: refs/heads/master@{#393236}

Powered by Google App Engine
This is Rietveld 408576698