Web animations: Supply CSS transition easing

Supply CSS transition easing when creating keyframes for CSS transitions

Linear easing was being supplied instead of the timing function specified by the user.

Example for testing: http://jsbin.com/sihif/1/quiet

Cubic bezier keyframe easings were being calculated without knowledge of the iteration duration. This led to inconsistency in the accuracy being requested.

We now always use the iteration duration when choosing the accuracy for timing function evaluation.

Without this, the transitions layout tests opacity-transform-transitions-inside-iframe.html and
cubic-bezier-overflow-length.html would have needed rebaselining.

BUG=352919
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169897

[Eric Willigers, 2014-03-20 12:11:10]

opacity-transform-transitions-inside-iframe.html and
cubic-bezier-overflow-length.html give slightly different results.

The reason is that a different accuracy value is being passed to the timing
function's evaluate method.

The original code called CubicBezierTimingFunction's evaluate using
specified.timingFunction->evaluate(timeFraction,
accuracyForDuration(iterationDuration) i.e. 0.005000 when iterationDuration is
1s);

The new code calls CubicBezierTimingFunction's evaluate using
record->m_easing->evaluate(localFraction, accuracyForKeyframeEasing i.e.
0.0000001);

[Eric Willigers, 2014-03-21 01:46:47]

PTAL

[Eric Willigers, 2014-03-21 04:20:58]

+dstockwell

[shans, 2014-03-21 04:41:40]

lgtm

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/In...
File Source/core/animation/InterpolationEffectTest.cpp (right):

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/In...
Source/core/animation/InterpolationEffectTest.cpp:12: const double kDuration =
1.0;
'duration' is fine.

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/Ke...
File Source/core/animation/KeyframeEffectModelTest.cpp (right):

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/Ke...
Source/core/animation/KeyframeEffectModelTest.cpp:45: const double kDuration =
1.0;
'duration'

[Eric Willigers, 2014-03-21 04:52:29]

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/In...
File Source/core/animation/InterpolationEffectTest.cpp (right):

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/In...
Source/core/animation/InterpolationEffectTest.cpp:12: const double kDuration =
1.0;
On 2014/03/21 04:41:41, shans wrote:
> 'duration' is fine.

Done.

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/Ke...
File Source/core/animation/KeyframeEffectModelTest.cpp (right):

https://codereview.chromium.org/196413030/diff/40001/Source/core/animation/Ke...
Source/core/animation/KeyframeEffectModelTest.cpp:45: const double kDuration =
1.0;
On 2014/03/21 04:41:41, shans wrote:
> 'duration'

Done.

[dstockwell, 2014-03-24 21:23:47]

lgtm

[commit-bot: I haz the power, 2014-03-24 21:23:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/196413030/6...

[commit-bot: I haz the power, 2014-03-24 21:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 21:25:06]

Failed to apply patch for Source/core/animation/KeyframeEffectModelTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/animation/KeyframeEffectModelTest.cpp
  Hunk #1 FAILED at 42.
  1 out of 21 hunks FAILED -- saving rejects to file
Source/core/animation/KeyframeEffectModelTest.cpp.rej

Patch:       Source/core/animation/KeyframeEffectModelTest.cpp
Index: Source/core/animation/KeyframeEffectModelTest.cpp
diff --git a/Source/core/animation/KeyframeEffectModelTest.cpp
b/Source/core/animation/KeyframeEffectModelTest.cpp
index
4d438eb09bbf42c58b67223703d02fc0a7d54195..9ddb7d84461b4d70744e39c5e30e5096a186795a
100644
--- a/Source/core/animation/KeyframeEffectModelTest.cpp
+++ b/Source/core/animation/KeyframeEffectModelTest.cpp
@@ -42,6 +42,8 @@ using namespace WebCore;
 
 namespace {
 
+const double duration = 1.0;
+
 PassRefPtr<AnimatableValue> unknownAnimatableValue(double n)
 {
     return AnimatableUnknown::create(CSSPrimitiveValue::create(n,
CSSPrimitiveValue::CSS_UNKNOWN).get());
@@ -101,7 +103,7 @@ TEST(AnimationKeyframeEffectModel, BasicOperation)
 {
     KeyframeEffectModel::KeyframeVector keyframes =
keyframesAtZeroAndOne(unknownAnimatableValue(3.0), unknownAnimatableValue(5.0));
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    OwnPtr<Vector<RefPtr<Interpolation> > > values = effect->sample(0, 0.6);
+    OwnPtr<Vector<RefPtr<Interpolation> > > values = effect->sample(0, 0.6,
duration);
     ASSERT_EQ(1UL, values->size());
     expectProperty(CSSPropertyLeft, values->at(0));
     expectDoubleValue(5.0, values->at(0));
@@ -113,7 +115,7 @@ TEST(AnimationKeyframeEffectModel,
CompositeReplaceNonInterpolable)
     keyframes[0]->setComposite(AnimationEffect::CompositeReplace);
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(5.0, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(5.0, effect->sample(0, 0.6, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, CompositeReplace)
@@ -122,7 +124,7 @@ TEST(AnimationKeyframeEffectModel, CompositeReplace)
     keyframes[0]->setComposite(AnimationEffect::CompositeReplace);
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(3.0 * 0.4 + 5.0 * 0.6, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(3.0 * 0.4 + 5.0 * 0.6, effect->sample(0, 0.6,
duration)->at(0));
 }
 
 // FIXME: Re-enable this test once compositing of CompositeAdd is supported.
@@ -132,7 +134,7 @@ TEST(AnimationKeyframeEffectModel, DISABLED_CompositeAdd)
     keyframes[0]->setComposite(AnimationEffect::CompositeAdd);
     keyframes[1]->setComposite(AnimationEffect::CompositeAdd);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue((7.0 + 3.0) * 0.4 + (7.0 + 5.0) * 0.6, effect->sample(0,
0.6)->at(0));
+    expectDoubleValue((7.0 + 3.0) * 0.4 + (7.0 + 5.0) * 0.6, effect->sample(0,
0.6, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, CompositeEaseIn)
@@ -143,7 +145,8 @@ TEST(AnimationKeyframeEffectModel, CompositeEaseIn)
    
keyframes[0]->setEasing(CSSToStyleMap::animationTimingFunction(timingFunction.get(),
false));
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(3.8582394, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(3.8579516, effect->sample(0, 0.6, duration)->at(0));
+    expectDoubleValue(3.8582394, effect->sample(0, 0.6, duration *
100)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, CompositeCubicBezier)
@@ -154,7 +157,8 @@ TEST(AnimationKeyframeEffectModel, CompositeCubicBezier)
    
keyframes[0]->setEasing(CSSToStyleMap::animationTimingFunction(timingFunction.get(),
false));
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(4.3362322, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(4.3363357, effect->sample(0, 0.6, duration)->at(0));
+    expectDoubleValue(4.3362322, effect->sample(0, 0.6, duration *
1000)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, ExtrapolateReplaceNonInterpolable)
@@ -163,7 +167,7 @@ TEST(AnimationKeyframeEffectModel,
ExtrapolateReplaceNonInterpolable)
     keyframes[0]->setComposite(AnimationEffect::CompositeReplace);
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(5.0, effect->sample(0, 1.6)->at(0));
+    expectDoubleValue(5.0, effect->sample(0, 1.6, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, ExtrapolateReplace)
@@ -172,7 +176,7 @@ TEST(AnimationKeyframeEffectModel, ExtrapolateReplace)
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
     keyframes[0]->setComposite(AnimationEffect::CompositeReplace);
     keyframes[1]->setComposite(AnimationEffect::CompositeReplace);
-    expectDoubleValue(3.0 * -0.6 + 5.0 * 1.6, effect->sample(0, 1.6)->at(0));
+    expectDoubleValue(3.0 * -0.6 + 5.0 * 1.6, effect->sample(0, 1.6,
duration)->at(0));
 }
 
 // FIXME: Re-enable this test once compositing of CompositeAdd is supported.
@@ -182,13 +186,13 @@ TEST(AnimationKeyframeEffectModel,
DISABLED_ExtrapolateAdd)
     keyframes[0]->setComposite(AnimationEffect::CompositeAdd);
     keyframes[1]->setComposite(AnimationEffect::CompositeAdd);
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue((7.0 + 3.0) * -0.6 + (7.0 + 5.0) * 1.6, effect->sample(0,
1.6)->at(0));
+    expectDoubleValue((7.0 + 3.0) * -0.6 + (7.0 + 5.0) * 1.6, effect->sample(0,
1.6, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, ZeroKeyframes)
 {
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(KeyframeEffectModel::KeyframeVector());
-    EXPECT_TRUE(effect->sample(0, 0.5)->isEmpty());
+    EXPECT_TRUE(effect->sample(0, 0.5, duration)->isEmpty());
 }
 
 // FIXME: Re-enable this test once compositing of CompositeAdd is supported.
@@ -200,7 +204,7 @@ TEST(AnimationKeyframeEffectModel,
DISABLED_SingleKeyframeAtOffsetZero)
     keyframes[0]->setPropertyValue(CSSPropertyLeft,
unknownAnimatableValue(3.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(3.0, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(3.0, effect->sample(0, 0.6, duration)->at(0));
 }
 
 // FIXME: Re-enable this test once compositing of CompositeAdd is supported.
@@ -212,7 +216,7 @@ TEST(AnimationKeyframeEffectModel,
DISABLED_SingleKeyframeAtOffsetOne)
     keyframes[0]->setPropertyValue(CSSPropertyLeft,
pixelAnimatableValue(5.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(7.0 * 0.4 + 5.0 * 0.6, effect->sample(0, 0.6)->at(0));
+    expectDoubleValue(7.0 * 0.4 + 5.0 * 0.6, effect->sample(0, 0.6,
duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, MoreThanTwoKeyframes)
@@ -229,8 +233,8 @@ TEST(AnimationKeyframeEffectModel, MoreThanTwoKeyframes)
     keyframes[2]->setPropertyValue(CSSPropertyLeft,
unknownAnimatableValue(5.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(4.0, effect->sample(0, 0.3)->at(0));
-    expectDoubleValue(5.0, effect->sample(0, 0.8)->at(0));
+    expectDoubleValue(4.0, effect->sample(0, 0.3, duration)->at(0));
+    expectDoubleValue(5.0, effect->sample(0, 0.8, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, EndKeyframeOffsetsUnspecified)
@@ -245,9 +249,9 @@ TEST(AnimationKeyframeEffectModel,
EndKeyframeOffsetsUnspecified)
     keyframes[2]->setPropertyValue(CSSPropertyLeft,
unknownAnimatableValue(5.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(3.0, effect->sample(0, 0.1)->at(0));
-    expectDoubleValue(4.0, effect->sample(0, 0.6)->at(0));
-    expectDoubleValue(5.0, effect->sample(0, 0.9)->at(0));
+    expectDoubleValue(3.0, effect->sample(0, 0.1, duration)->at(0));
+    expectDoubleValue(4.0, effect->sample(0, 0.6, duration)->at(0));
+    expectDoubleValue(5.0, effect->sample(0, 0.9, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, SampleOnKeyframe)
@@ -264,9 +268,9 @@ TEST(AnimationKeyframeEffectModel, SampleOnKeyframe)
     keyframes[2]->setPropertyValue(CSSPropertyLeft,
unknownAnimatableValue(5.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(3.0, effect->sample(0, 0.0)->at(0));
-    expectDoubleValue(4.0, effect->sample(0, 0.5)->at(0));
-    expectDoubleValue(5.0, effect->sample(0, 1.0)->at(0));
+    expectDoubleValue(3.0, effect->sample(0, 0.0, duration)->at(0));
+    expectDoubleValue(4.0, effect->sample(0, 0.5, duration)->at(0));
+    expectDoubleValue(5.0, effect->sample(0, 1.0, duration)->at(0));
 }
 
 TEST(AnimationKeyframeEffectModel, MultipleKeyframesWithSameOffset)
@@ -301,13 +305,13 @@ TEST(AnimationKeyframeEffectModel,
MultipleKeyframesWithSameOffset)
     keyframes[8]->setPropertyValue(CSSPropertyLeft,
unknownAnimatableValue(7.0).get());
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
-    expectDoubleValue(0.0, effect->sample(0, 0.0)->at(0));
-    expectDoubleValue(2.0, effect->sample(0, 0.2)->at(0));
-    expectDoubleValue(3.0, effect->sample(0, 0.4)->at(0));
-    expectDouble…
(message too large)

[Eric Willigers, 2014-03-25 00:12:50]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:13:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/196413030/8...

[commit-bot: I haz the power, 2014-03-25 00:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:14:27]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[Eric Willigers, 2014-03-25 01:11:22]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2014-03-25 01:11:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/196413030/8...

[commit-bot: I haz the power, 2014-03-25 01:27:22]

Change committed as 169897